Reflection::toString() appends () after function/method name

Author: dg

composer.json

@@ -22,6 +22,9 @@
 		"tracy/tracy": "^2.3",
 		"phpstan/phpstan": "^0.12"
 	},
+	"conflict": {
+		"nette/di": "<3.0.6"
+	},
 	"suggest": {
 		"ext-iconv": "to use Strings::webalize(), toAscii(), chr() and reverse()",
 		"ext-json": "to use Nette\\Utils\\Json",

src/Utils/Reflection.php

@@ -246,13 +246,13 @@ public static function toString(\Reflector $ref): string
 		if ($ref instanceof \ReflectionClass) {
 			return $ref->name;
 		} elseif ($ref instanceof \ReflectionMethod) {
-			return $ref->getDeclaringClass()->name . '::' . $ref->name;
+			return $ref->getDeclaringClass()->name . '::' . $ref->name . '()';
 		} elseif ($ref instanceof \ReflectionFunction) {
-			return $ref->name;
+			return $ref->name . '()';
 		} elseif ($ref instanceof \ReflectionProperty) {
 			return self::getPropertyDeclaringClass($ref)->name . '::$' . $ref->name;
 		} elseif ($ref instanceof \ReflectionParameter) {
-			return '$' . $ref->name . ' in ' . self::toString($ref->getDeclaringFunction()) . '()';
+			return '$' . $ref->name . ' in ' . self::toString($ref->getDeclaringFunction());
 		} else {
 			throw new Nette\InvalidArgumentException;
 		}

tests/Utils/Reflection.getReturnType.80.phpt

@@ -121,11 +121,11 @@ namespace
 
 	Assert::exception(function () {
 		Reflection::getReturnType(new \ReflectionMethod(NS\A::class, 'unionType'));
-	}, Nette\InvalidStateException::class, 'The NS\A::unionType is not expected to have a union type.');
+	}, Nette\InvalidStateException::class, 'The NS\A::unionType() is not expected to have a union type.');
 
 	Assert::exception(function () {
 		Reflection::getReturnType(new \ReflectionMethod(NS\A::class, 'nullableUnionType'));
-	}, Nette\InvalidStateException::class, 'The NS\A::nullableUnionType is not expected to have a union type.');
+	}, Nette\InvalidStateException::class, 'The NS\A::nullableUnionType() is not expected to have a union type.');
 
 	Assert::same('NS\A', Reflection::getReturnType(new \ReflectionMethod(NS\AExt::class, 'parentTypeExt')));
 
@@ -139,5 +139,5 @@ namespace
 
 	Assert::exception(function () {
 		Reflection::getReturnType(new \ReflectionFunction('NS\unionType'));
-	}, Nette\InvalidStateException::class, 'The NS\unionType is not expected to have a union type.');
+	}, Nette\InvalidStateException::class, 'The NS\unionType() is not expected to have a union type.');
 }

tests/Utils/Reflection.toString.phpt

@@ -29,8 +29,8 @@ function func($param)
 
 
 Assert::same('Foo', Reflection::toString(new ReflectionClass('Foo')));
-Assert::same('Foo::method', Reflection::toString(new ReflectionMethod('Foo', 'method')));
+Assert::same('Foo::method()', Reflection::toString(new ReflectionMethod('Foo', 'method')));
 Assert::same('$param in Foo::method()', Reflection::toString(new ReflectionParameter(['Foo', 'method'], 'param')));
 Assert::same('Foo::$var', Reflection::toString(new ReflectionProperty('Foo', 'var')));
-Assert::same('func', Reflection::toString(new ReflectionFunction('func')));
+Assert::same('func()', Reflection::toString(new ReflectionFunction('func')));
 Assert::same('$param in func()', Reflection::toString(new ReflectionParameter('func', 'param')));