Strings::length() uses mbstring, iconv and then utf8_decode [Closes #299]

dg · dg · commit 380966d69109 · 2023-09-19T13:57:55.000+02:00
diff --git a/src/Utils/Strings.php b/src/Utils/Strings.php
@@ -397,9 +397,11 @@ public static function findPrefix(array $strings): string
 	 */
 	public static function length(string $s): int
 	{
-		return function_exists('mb_strlen')
-			? mb_strlen($s, 'UTF-8')
-			: strlen(utf8_decode($s));
+		return match (true) {
+			extension_loaded('mbstring') => mb_strlen($s, 'UTF-8'),
+			extension_loaded('iconv') => iconv_strlen($s, 'UTF-8'),
+			default => strlen(@utf8_decode($s)), // deprecated
+		};
 	}
 
 

Original file line number	Diff line number	Diff line change
`@@ -397,9 +397,11 @@ public static function findPrefix(array $strings): string`
`397`	`397`	`*/`
`398`	`398`	`public static function length(string $s): int`
`399`	`399`	`{`
`400`		`- return function_exists('mb_strlen')`
`401`		`- ? mb_strlen($s, 'UTF-8')`
`402`		`- : strlen(utf8_decode($s));`
	`400`	`+ return match (true) {`
	`401`	`+ extension_loaded('mbstring') => mb_strlen($s, 'UTF-8'),`
	`402`	`+ extension_loaded('iconv') => iconv_strlen($s, 'UTF-8'),`
	`403`	`+ default => strlen(@utf8_decode($s)), // deprecated`
	`404`	`+ };`
`403`	`405`	`}`
`404`	`406`
`405`	`407`