travis: add PHPStan [Closes #157]

Author: JanTvrdik

.travis.yml

@@ -26,10 +26,14 @@ jobs:
                 - travis_retry composer create-project nette/code-checker temp/code-checker ~2 --no-progress
                 # Install Nette Coding Standard
                 - travis_retry composer create-project nette/coding-standard temp/coding-standard --no-progress
+                # Install PHPStan
+                - travis_retry composer create-project phpstan/phpstan-shim temp/phpstan --no-progress
+                - travis_retry composer install --no-progress --prefer-dist
 
             script:
                 - php temp/code-checker/src/code-checker.php --short-arrays --strict-types -i tests/Utils/fixtures.reflection
                 - php temp/coding-standard/ecs check src tests --config tests/coding-standard.neon
+                - php temp/phpstan/phpstan.phar analyse --autoload-file vendor/autoload.php --level 7 --configuration tests/phpstan.neon src
 
 
         -   stage: Code Coverage

src/Utils/Html.php

@@ -311,7 +311,7 @@ final public function getHtml(): string
 
 	/**
 	 * Sets element's textual content.
-	 * @param  IHtmlString|string  $text
+	 * @param  IHtmlString|string|int|float  $text
 	 * @return static
 	 */
 	final public function setText($text)

tests/Utils/Html.basic.phpt

@@ -58,7 +58,7 @@ test(function () {
 
 
 test(function () {
-	$el = Html::el('img')->src('image.gif')->alt('')->setText(null)->setText('any content');
+	$el = Html::el('img')->src('image.gif')->alt('')->setText('any content');
 	Assert::same('<img src="image.gif" alt="" />', (string) $el);
 	Assert::same('<img src="image.gif" alt="" />', $el->startTag());
 	Assert::same('', $el->endTag());

tests/phpstan-bootstrap.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+if (!function_exists('imagewebp')) {
+	function imagewebp($image, $to = null, int $quality = 80): bool
+	{
+	}
+}

tests/phpstan.neon

@@ -0,0 +1,12 @@
+parameters:
+	bootstrap: tests/phpstan-bootstrap.php
+
+	ignoreErrors:
+		# PHPStan does not support dynamic by reference return used by Nette\Utils\Strings::pcre()
+		- '#Undefined variable: \$m#'
+
+		# PHPStan does not support RecursiveIteratorIterator proxying unknown method calls to inner iterator
+		- '#RecursiveIteratorIterator::getSubPathName\(\)#'
+
+		# PHPStan does not support comparing null
+		- '#Nette\\Utils\\Strings::substring\(\) expects int, int\|null given#'