Image::save() and send() throws ImageException on failure (BC break)

Author: dg

src/Utils/Image.php

@@ -507,9 +507,10 @@ public function place(Image $image, $left = 0, $top = 0, int $opacity = 100): se
 	 * @param  string  filename
 	 * @param  int  quality (0..100 for JPEG and WEBP, 0..9 for PNG)
 	 * @param  int  optional image type
-	 * @return bool TRUE on success or FALSE on failure.
+	 * @return void
+	 * @throws ImageException
 	 */
-	public function save(string $file = NULL, int $quality = NULL, int $type = NULL): bool
+	public function save(string $file = NULL, int $quality = NULL, int $type = NULL)
 	{
 		if ($type === NULL) {
 			$extensions = array_flip(self::$formats) + ['jpg' => self::JPEG];
@@ -523,22 +524,29 @@ public function save(string $file = NULL, int $quality = NULL, int $type = NULL)
 		switch ($type) {
 			case self::JPEG:
 				$quality = $quality === NULL ? 85 : max(0, min(100, $quality));
-				return imagejpeg($this->image, $file, $quality);
+				$success = imagejpeg($this->image, $file, $quality);
+				break;
 
 			case self::PNG:
 				$quality = $quality === NULL ? 9 : max(0, min(9, $quality));
-				return imagepng($this->image, $file, $quality);
+				$success = imagepng($this->image, $file, $quality);
+				break;
 
 			case self::GIF:
-				return imagegif($this->image, $file);
+				$success = imagegif($this->image, $file);
+				break;
 
 			case self::WEBP:
 				$quality = $quality === NULL ? 80 : max(0, min(100, $quality));
-				return imagewebp($this->image, $file, $quality);
+				$success = imagewebp($this->image, $file, $quality);
+				break;
 
 			default:
 				throw new Nette\InvalidArgumentException("Unsupported image type '$type'.");
 		}
+		if (!$success) {
+			throw new ImageException(error_get_last()['message']);
+		}
 	}
 
 
@@ -577,15 +585,16 @@ public function __toString(): string
 	 * Outputs image to browser.
 	 * @param  int  image type
 	 * @param  int  quality (0..100 for JPEG and WEBP, 0..9 for PNG)
-	 * @return bool TRUE on success or FALSE on failure.
+	 * @return void
+	 * @throws ImageException
 	 */
-	public function send(int $type = self::JPEG, int $quality = NULL): bool
+	public function send(int $type = self::JPEG, int $quality = NULL)
 	{
 		if (!isset(self::$formats[$type])) {
 			throw new Nette\InvalidArgumentException("Unsupported image type '$type'.");
 		}
 		header('Content-Type: image/' . self::$formats[$type]);
-		return $this->save(NULL, $quality, $type);
+		$this->save(NULL, $quality, $type);
 	}