Validators::everyIs: first argument has typehint iterable (BC break)

Author: dg

src/Utils/Validators.php

@@ -111,7 +111,7 @@ public static function is($value, string $expected): bool
 	{
 		foreach (explode('|', $expected) as $item) {
 			if (substr($item, -2) === '[]') {
-				if (self::everyIs($value, substr($item, 0, -2))) {
+				if (is_iterable($value) && self::everyIs($value, substr($item, 0, -2))) {
 					return true;
 				}
 				continue;
@@ -152,13 +152,9 @@ public static function is($value, string $expected): bool
 
 	/**
 	 * Finds whether all values are of expected type (separated by pipe).
-	 * @param  iterable
 	 */
-	public static function everyIs($values, string $expected): bool
+	public static function everyIs(iterable $values, string $expected): bool
 	{
-		if (!is_iterable($values)) {
-			return false;
-		}
 		foreach ($values as $value) {
 			if (!static::is($value, $expected)) {
 				return false;

tests/Utils/Validators.everyIs().phpt

@@ -21,8 +21,6 @@ test(function () {
 	Assert::true(Validators::everyIs([], 'int'));
 	Assert::true(Validators::everyIs(new ArrayIterator([]), 'int'));
 
-	Assert::false(Validators::everyIs(1, 'int'));
-	Assert::false(Validators::everyIs(2.15, 'int'));
 	Assert::true(Validators::everyIs([1, 2, 3], 'int'));
 	Assert::false(Validators::everyIs([1, 2.15, 3], 'int'));
 	Assert::true(Validators::everyIs([1, 2.15, 3], 'int|float'));
@@ -50,10 +48,11 @@ test(function () {
 		yield 3;
 	};
 	Assert::true(Validators::everyIs($gen(), 'int'));
+});
+
 
+Assert::exception(function () {
 	$var = new stdClass;
 	$var->a = 1;
-	$var->b = 2;
-	$var->c = 3;
-	Assert::false(Validators::everyIs($var, 'int'));
-});
+	Validators::everyIs($var, 'int');
+}, TypeError::class);