removed useless type juggling

Author: dg

src/Utils/Html.php

@@ -89,12 +89,8 @@ public static function el(string $name = NULL, $attrs = NULL)
 	 */
 	public function setName(string $name, bool $isEmpty = NULL)
 	{
-		if ($name !== NULL && !is_string($name)) {
-			throw new Nette\InvalidArgumentException(sprintf('Name must be string or NULL, %s given.', gettype($name)));
-		}
-
 		$this->name = $name;
-		$this->isEmpty = $isEmpty === NULL ? isset(static::$emptyElements[$name]) : (bool) $isEmpty;
+		$this->isEmpty = $isEmpty === NULL ? isset(static::$emptyElements[$name]) : $isEmpty;
 		return $this;
 	}
 
@@ -351,7 +347,7 @@ public function setText($text)
 		if (!is_array($text) && !$text instanceof self) {
 			$text = htmlspecialchars((string) $text, ENT_NOQUOTES, 'UTF-8');
 		}
-		return $this->setHtml($text);
+		return $this->setHtml((string) $text);
 	}
 
 
@@ -416,7 +412,7 @@ public function insert(int $index = NULL, $child, bool $replace = FALSE)
 				$this->children[] = $child;
 
 			} else { // insert or replace
-				array_splice($this->children, (int) $index, $replace ? 1 : 0, [$child]);
+				array_splice($this->children, $index, $replace ? 1 : 0, [$child]);
 			}
 
 		} else {

src/Utils/Image.php

@@ -132,10 +132,10 @@ class Image
 	public static function rgb(int $red, int $green, int $blue, int $transparency = 0): array
 	{
 		return [
-			'red' => max(0, min(255, (int) $red)),
-			'green' => max(0, min(255, (int) $green)),
-			'blue' => max(0, min(255, (int) $blue)),
-			'alpha' => max(0, min(127, (int) $transparency)),
+			'red' => max(0, min(255, $red)),
+			'green' => max(0, min(255, $green)),
+			'blue' => max(0, min(255, $blue)),
+			'alpha' => max(0, min(127, $transparency)),
 		];
 	}
 
@@ -162,7 +162,7 @@ public static function fromFile(string $file, int &$format = NULL)
 			$format = NULL;
 			throw new UnknownImageFileException(is_file($file) ? "Unknown type of file '$file'." : "File '$file' not found.");
 		}
-		return new static(Callback::invokeSafe('imagecreatefrom' . self::$formats[$format], [$file], function ($message) {
+		return new static(Callback::invokeSafe('imagecreatefrom' . self::$formats[$format], [$file], function (string $message) {
 			throw new ImageException($message);
 		}));
 	}
@@ -186,7 +186,7 @@ public static function fromString(string $s, int &$format = NULL)
 			$format = isset(self::$formats[$tmp]) ? $tmp : NULL;
 		}
 
-		return new static(Callback::invokeSafe('imagecreatefromstring', [$s], function ($message) {
+		return new static(Callback::invokeSafe('imagecreatefromstring', [$s], function (string $message) {
 			throw new ImageException($message);
 		}));
 	}
@@ -205,14 +205,12 @@ public static function fromBlank(int $width, int $height, array $color = NULL)
 			throw new Nette\NotSupportedException('PHP extension GD is not loaded.');
 		}
 
-		$width = (int) $width;
-		$height = (int) $height;
 		if ($width < 1 || $height < 1) {
 			throw new Nette\InvalidArgumentException('Image width and height must be greater than zero.');
 		}
 
 		$image = imagecreatetruecolor($width, $height);
-		if (is_array($color)) {
+		if ($color) {
 			$color += ['alpha' => 0];
 			$color = imagecolorresolvealpha($image, $color['red'], $color['green'], $color['blue'], $color['alpha']);
 			imagealphablending($image, FALSE);
@@ -457,7 +455,7 @@ public function sharpen()
 	 */
 	public function place(Image $image, $left = 0, $top = 0, int $opacity = 100)
 	{
-		$opacity = max(0, min(100, (int) $opacity));
+		$opacity = max(0, min(100, $opacity));
 		if ($opacity === 0) {
 			return $this;
 		}
@@ -524,18 +522,18 @@ public function save(string $file = NULL, int $quality = NULL, int $type = NULL)
 
 		switch ($type) {
 			case self::JPEG:
-				$quality = $quality === NULL ? 85 : max(0, min(100, (int) $quality));
+				$quality = $quality === NULL ? 85 : max(0, min(100, $quality));
 				return imagejpeg($this->image, $file, $quality);
 
 			case self::PNG:
-				$quality = $quality === NULL ? 9 : max(0, min(9, (int) $quality));
+				$quality = $quality === NULL ? 9 : max(0, min(9, $quality));
 				return imagepng($this->image, $file, $quality);
 
 			case self::GIF:
 				return imagegif($this->image, $file);
 
 			case self::WEBP:
-				$quality = $quality === NULL ? 80 : max(0, min(100, (int) $quality));
+				$quality = $quality === NULL ? 80 : max(0, min(100, $quality));
 				return imagewebp($this->image, $file, $quality);
 
 			default:

src/Utils/Paginator.php

@@ -52,7 +52,7 @@ class Paginator
 	 */
 	public function setPage(int $page)
 	{
-		$this->page = (int) $page;
+		$this->page = $page;
 		return $this;
 	}
 
@@ -94,7 +94,7 @@ public function getLastPage()
 	 */
 	public function setBase(int $base)
 	{
-		$this->base = (int) $base;
+		$this->base = $base;
 		return $this;
 	}
 
@@ -157,7 +157,7 @@ public function getPageCount()
 	 */
 	public function setItemsPerPage(int $itemsPerPage)
 	{
-		$this->itemsPerPage = max(1, (int) $itemsPerPage);
+		$this->itemsPerPage = max(1, $itemsPerPage);
 		return $this;
 	}
 
@@ -179,7 +179,7 @@ public function getItemsPerPage(): int
 	 */
 	public function setItemCount(int $itemCount = NULL)
 	{
-		$this->itemCount = ($itemCount === FALSE || $itemCount === NULL) ? NULL : max(0, (int) $itemCount);
+		$this->itemCount = $itemCount === NULL ? NULL : max(0, $itemCount);
 		return $this;
 	}
 

src/Utils/Strings.php

@@ -586,7 +586,7 @@ public static function pcre(string $func, array $args)
 			PREG_BAD_UTF8_OFFSET_ERROR => 'Offset didn\'t correspond to the begin of a valid UTF-8 code point',
 			6 => 'Failed due to limited JIT stack space', // PREG_JIT_STACKLIMIT_ERROR
 		];
-		$res = Callback::invokeSafe($func, $args, function ($message) use ($args) {
+		$res = Callback::invokeSafe($func, $args, function (string $message) use ($args) {
 			// compile-time error, not detectable by preg_last_error
 			throw new RegexpException($message . ' in pattern: ' . implode(' or ', (array) $args[0]));
 		});