Validator:: accepts the plus character as a valid option in numeric strings (#184)

Author: Amunak

src/Utils/Validators.php

@@ -178,7 +178,7 @@ public static function isNumber($value): bool
 	 */
 	public static function isNumericInt($value): bool
 	{
-		return is_int($value) || is_string($value) && preg_match('#^-?[0-9]+\z#', $value);
+		return is_int($value) || is_string($value) && preg_match('#^[+-]?[0-9]+\z#', $value);
 	}
 
 
@@ -187,7 +187,7 @@ public static function isNumericInt($value): bool
 	 */
 	public static function isNumeric($value): bool
 	{
-		return is_float($value) || is_int($value) || is_string($value) && preg_match('#^-?[0-9]*[.]?[0-9]+\z#', $value);
+		return is_float($value) || is_int($value) || is_string($value) && preg_match('#^[+-]?[0-9]*[.]?[0-9]+\z#', $value);
 	}
 
 

tests/Utils/Validators.is().phpt

@@ -55,6 +55,9 @@ test(function () {
 	Assert::true(Validators::is('-1', 'numeric'));
 	Assert::true(Validators::is('-1.5', 'numeric'));
 	Assert::true(Validators::is('-.5', 'numeric'));
+	Assert::true(Validators::is('+1', 'numeric'));
+	Assert::true(Validators::is('+1.5', 'numeric'));
+	Assert::true(Validators::is('+.5', 'numeric'));
 	Assert::false(Validators::is('1e6', 'numeric'));
 	Assert::true(Validators::is(1, 'numeric'));
 	Assert::true(Validators::is(1.0, 'numeric'));
@@ -67,6 +70,9 @@ test(function () {
 	Assert::true(Validators::is('-1', 'numericint'));
 	Assert::false(Validators::is('-1.5', 'numericint'));
 	Assert::false(Validators::is('-.5', 'numericint'));
+	Assert::true(Validators::is('+1', 'numericint'));
+	Assert::false(Validators::is('+1.5', 'numericint'));
+	Assert::false(Validators::is('+.5', 'numericint'));
 	Assert::false(Validators::is('1e6', 'numericint'));
 	Assert::true(Validators::is(1, 'numericint'));
 	Assert::false(Validators::is(1.0, 'numericint'));