Skip to content

Commit 53dec46

Browse files
authored
Revised build-and-publish.yml to continue regardless of jsdoc lint er… (#53)
Revised build-and-publish.yml to continue regardless of jsdoc lint errors. Workflow will still check for missing jsdoc annotation, but will return either a pass or non-blocking warning.
1 parent 906c1c6 commit 53dec46

File tree

3 files changed

+14
-12
lines changed

3 files changed

+14
-12
lines changed

.github/workflows/build-and-publish.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,23 +80,25 @@ jobs:
8080
- name: Install jq
8181
run: sudo apt-get install -y jq
8282

83-
# Check for proper JSDoc annnotations
8483
- name: Run JSDoc lint check
84+
id: jsdoc_lint
85+
continue-on-error: true
8586
run: |
8687
set -e
8788
output=$(npm run lint:jsdoc || true)
8889
echo "$output"
8990
9091
count=$(echo "$output" | wc -l)
91-
if [ "$count" -gt 0 ]; then
92-
echo "❌ JSDoc lint check failed with $count violations."
93-
exit 1
94-
fi
92+
echo "jsdoc_count=$count" >> "$GITHUB_OUTPUT"
9593
9694
- name: ✅ Pass
97-
if: success()
95+
if: steps.jsdoc_lint.outputs.jsdoc_count == '0'
9896
run: echo "JSDoc lint passed successfully!"
9997

98+
- name: ⚠️ JSDoc violations detected (non-blocking)
99+
if: steps.jsdoc_lint.outputs.jsdoc_count != '0'
100+
run: echo "⚠️ JSDoc lint check failed with ${{ steps.jsdoc_lint.outputs.jsdoc_count }} violations (non-blocking)"
101+
100102
# Check utility scripts for unit tests
101103
- name: Audit utility scripts (non-blocking)
102104
run: npm run audit:scripts || true

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@networkpro/web",
33
"private": false,
44
"sideEffects": false,
5-
"version": "1.4.1",
5+
"version": "1.4.2",
66
"description": "Locking Down Networks, Unlocking Confidence | Security, Networking, Privacy — Network Pro Strategies",
77
"keywords": [
88
"security",

0 commit comments

Comments
 (0)