Skip to content

Commit d45873e

Browse files
committed
Merge remote-tracking branch 'origin/master' into audit-netlify
2 parents e21fd98 + 18d5f4d commit d45873e

File tree

21 files changed

+1031
-539
lines changed

21 files changed

+1031
-539
lines changed

.github/workflows/build-and-publish.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
- name: Upgrade npm
4646
run: |
4747
corepack enable
48-
npm install -g npm@11.6.2
48+
npm install -g npm@11.7.0
4949
5050
- name: Install Node.js dependencies
5151
run: npm ci
@@ -130,7 +130,7 @@ jobs:
130130
- name: Upgrade npm
131131
run: |
132132
corepack enable
133-
npm install -g npm@11.6.2
133+
npm install -g npm@11.7.0
134134
135135
- name: Install Node.js dependencies
136136
run: npm ci
@@ -186,7 +186,7 @@ jobs:
186186
- name: Upgrade npm
187187
run: |
188188
corepack enable
189-
npm install -g npm@11.6.2
189+
npm install -g npm@11.7.0
190190
191191
- name: Install Node.js dependencies
192192
run: npm ci

.github/workflows/check-security-txt-expiry.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ permissions:
1010

1111
jobs:
1212
check-expiry:
13-
runs-on: ubuntu-latest
13+
runs-on: ubuntu-24.04
1414
name: Validate .well-known/security.txt expiration
1515
env:
1616
ENV_MODE: ci

.github/workflows/lighthouse.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
- name: Upgrade npm
5252
run: |
5353
corepack enable
54-
npm install -g npm@11.6.2
54+
npm install -g npm@11.7.0
5555
5656
- name: Clean previous Lighthouse reports
5757
run: |

.github/workflows/playwright.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
- name: Upgrade npm
4242
run: |
4343
corepack enable
44-
npm install -g npm@11.6.2
44+
npm install -g npm@11.7.0
4545
4646
- name: Install Node.js dependencies
4747
run: npm ci

.github/workflows/publish-test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
- name: Upgrade npm
4949
run: |
5050
corepack enable
51-
npm install -g npm@11.6.2
51+
npm install -g npm@11.7.0
5252
5353
- name: Install Node.js dependencies
5454
run: npm ci
@@ -134,7 +134,7 @@ jobs:
134134
- name: Upgrade npm
135135
run: |
136136
corepack enable
137-
npm install -g npm@11.6.2
137+
npm install -g npm@11.7.0
138138
139139
- name: Install Node.js dependencies
140140
run: npm ci
@@ -195,7 +195,7 @@ jobs:
195195
- name: Upgrade npm
196196
run: |
197197
corepack enable
198-
npm install -g npm@11.6.2
198+
npm install -g npm@11.7.0
199199
200200
- name: Install Node.js dependencies
201201
run: npm ci

.github/workflows/templates/publish.template.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
- name: Upgrade npm
5454
run: |
5555
corepack enable
56-
npm install -g npm@11.6.2
56+
npm install -g npm@11.7.0
5757
5858
- name: Install Node.js dependencies
5959
run: npm ci
@@ -134,7 +134,7 @@ jobs:
134134
- name: Upgrade npm
135135
run: |
136136
corepack enable
137-
npm install -g npm@11.6.2
137+
npm install -g npm@11.7.0
138138
139139
- name: Install Node.js dependencies
140140
run: npm ci
@@ -190,7 +190,7 @@ jobs:
190190
- name: Upgrade npm
191191
run: |
192192
corepack enable
193-
npm install -g npm@11.6.2
193+
npm install -g npm@11.7.0
194194
195195
- name: Install Node.js dependencies
196196
run: npm ci

.ncurc.cjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ This file is part of Network Pro.
3131
/** @type {import('npm-check-updates').RunOptions} */
3232
module.exports = {
3333
// Ignore specific dependencies (prevent upgrades)
34-
reject: ['vitest', '@vitest/coverage-v8', 'prettier', 'jsdom'],
34+
reject: ['vitest', '@vitest/coverage-v8', 'prettier'],
3535

3636
// Always upgrade devDependencies as well
3737
dep: 'prod,dev',

CHANGELOG.md

Lines changed: 65 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,69 @@ This project attempts to follow [Keep a Changelog](https://keepachangelog.com/en
2222

2323
---
2424

25+
## [1.25.17] - 2025-12-11
26+
27+
### Added
28+
29+
- Added SSR boundary protection test (`tests/unit/server/internal/ssrBoundary.test.js`):
30+
- Detects Node-only imports (`jsdom`, `fs`, `path`, etc.) in client-visible modules.
31+
- Ensures imports are properly gated behind `import.meta.env.SSR`.
32+
- Prevents accidental SSR/client boundary violations in future code changes.
33+
- Added support for detecting SSR-safe code paths by allowing SSR-gated dynamic imports in shared modules.
34+
35+
### Changed
36+
37+
- Refactored `src/service-worker.js` for improved consistency, clarity, and lint compatibility:
38+
- Removed unused function parameters (`_err`) and adjusted callback signatures to align with ESLint expectations.
39+
- Replaced anonymous no-op parameters with explicitly ignored placeholders using the `_` naming convention.
40+
- Improved async iteration patterns in asset caching logic for better readability and maintainability.
41+
- Updated JSDoc annotations for accuracy and improved editor support.
42+
- Ensured all cache operations conform to structured error-handling patterns consistent with the rest of the codebase.
43+
44+
- Updated `src/lib/utils/purify.js`:
45+
- Replaced `typeof window !== 'undefined'` guard with compile-time `import.meta.env.SSR`.
46+
- Ensures Vite tree-shakes `jsdom` imports from client bundles.
47+
- Fixed build failures caused by jsdom/cssstyle when bundled on the client.
48+
- Preserves existing DOMPurify caching and SSR behavior.
49+
50+
- Enhanced ESLint `no-unused-vars` rule in `eslint.config.mjs`:
51+
- Added support for ignoring unused catch parameters via `caughtErrors` and `caughtErrorsIgnorePattern`.
52+
- Prevented false positives on intentionally unused error variables (e.g., `_err`).
53+
- Expanded ignore patterns to match project coding conventions.
54+
55+
- Replaced `src/lib/img/qr/vcard.png` and `src/lib/img/qr/vcard.webp` with revised versions.
56+
- Updated GitHub workflows to utilize **npm** `11.7.0`.
57+
- Updated generator metadata in `src/app.html` to reflect **SvelteKit 2.49.2**.
58+
- Updated `src/lib/README.md` to reflect the newly updated app constant.
59+
- Updated contact information in `static/bin/contact.vcf`.
60+
- Updated `CONTACT.PHONE` app constant to reflect our new phone number, (602) 428-5300.
61+
- Removed `jsdom` from `.ncurc.cjs` `reject` list.
62+
- Bumped project version to `v1.25.17`.
63+
- Updated dependencies:
64+
- `dompurify` `^3.3.0``^3.3.1`
65+
- `posthog-js` `^1.295.0``^1.305.0`
66+
- `svelte` `5.43.12``5.45.9`
67+
- `@playwright/test` `^1.56.1``^1.57.0`
68+
- `@sveltejs/adapter-vercel` `^6.1.1``^6.2.0`
69+
- `@sveltejs/kit` `2.48.5``2.49.2`
70+
- `browserslist` `^4.28.0``^4.28.1`
71+
- `eslint-plugin-jsdoc` `^61.2.1``^61.5.0`
72+
- `eslint-plugin-svelte` `^3.13.0``^3.13.1`
73+
- `markdownlint` `^0.39.0``^0.40.0`
74+
- `markdownlint-cli2` `0.19.0``0.20.0`
75+
- `playwright` `^1.56.1``^1.57.0`
76+
- `stylelint` `^16.25.0``^16.26.1`
77+
- `svelte-eslint-parser` `^1.4.0``^1.4.1`
78+
- `vite` `^7.2.2``^7.2.7`
79+
- `jsdom` `26.1.0``27.3.0`
80+
81+
### Fixed
82+
83+
- Resolved client-side build failures caused by dynamic jsdom imports leaking into the Vite dependency graph.
84+
- Resolved false positive ESLint errors for unused catch bindings in JS modules.
85+
86+
---
87+
2588
## [1.25.16] - 2025-11-18
2689

2790
### Changed
@@ -1961,7 +2024,8 @@ This enables analytics filtering and CSP hardening for the audit environment.
19612024

19622025
<!-- Link references -->
19632026

1964-
[Unreleased]: https://github.com/netwk-pro/netwk-pro.github.io/compare/v1.25.16...HEAD
2027+
[Unreleased]: https://github.com/netwk-pro/netwk-pro.github.io/compare/v1.25.17...HEAD
2028+
[1.25.17]: https://github.com/netwk-pro/netwk-pro.github.io/releases/tag/v1.25.17
19652029
[1.25.16]: https://github.com/netwk-pro/netwk-pro.github.io/releases/tag/v1.25.16
19662030
[1.25.15]: https://github.com/netwk-pro/netwk-pro.github.io/releases/tag/v1.25.15
19672031
[1.25.14]: https://github.com/netwk-pro/netwk-pro.github.io/releases/tag/v1.25.14

eslint.config.mjs

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,27 @@ export default [
6565
...js.configs.recommended.rules, // ESLint's core recommended rules (scoped)
6666
...eslintConfigPrettier.rules, // Prettier config to disable conflicting ESLint rules (scoped)
6767
...ESLINT_RULES, // Additional custom rules
68-
'no-unused-vars': ['error', { argsIgnorePattern: '^_' }], // Ignore unused variables starting with an underscore
68+
69+
// Updated unused variable handling:
70+
// - Ignore args starting with "_"
71+
// - Ignore vars starting with "_"
72+
// - Allow unused catch variables named "_err" or any "_*"
73+
'no-unused-vars': [
74+
'error',
75+
{
76+
argsIgnorePattern: '^_',
77+
varsIgnorePattern: '^_',
78+
caughtErrors: 'all',
79+
caughtErrorsIgnorePattern: '^_',
80+
},
81+
],
82+
6983
'jsdoc/check-alignment': 'warn', // Ensure JSDoc block tags are aligned
7084
'jsdoc/check-param-names': 'warn', // Checks parameter names in JSDoc
71-
// Updated rule to allow the @updated tag
7285
'jsdoc/check-tag-names': [
7386
'warn',
7487
{
75-
definedTags: ['updated'],
88+
definedTags: ['updated'], // Allow custom @updated tag
7689
},
7790
],
7891
'jsdoc/check-types': 'warn', // Checks if types in JSDoc are defined correctly

0 commit comments

Comments
 (0)