Merge branch 'master' of https://github.com/networknt/json-schema-validator into fix/#138-date-validation

Author: jiachen1120

CHANGELOG.md

@@ -9,6 +9,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
+## 1.0.9 - 2019-05-21
+
+### Added
+
+### Changed
+
+- fixes #147 Fails to validate MIN and MAX when number type is converted to BigInteger. Thanks @jiachen1120
+
 ## 1.0.8 - 2019-05-17
 
 ### Added

pom.xml

@@ -19,7 +19,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>com.networknt</groupId>
     <artifactId>json-schema-validator</artifactId>
-    <version>1.0.8</version>
+    <version>1.0.9</version>
     <packaging>bundle</packaging>
     <description>A json schema validator that supports draft v4</description>
     <url>https://github.com/networknt/json-schema-validator</url>

src/main/java/com/networknt/schema/MaximumValidator.java

@@ -71,7 +71,11 @@ public String thresholdValue() {
                 @Override
                 public boolean crossesThreshold(JsonNode node) {
                     long val = node.asLong();
-                    return node.isBigInteger() || lm < val || (excludeEqual && lm <= val);
+                    if(node.isBigInteger()) {
+                        //node.isBigInteger is not trustable, the type BigInteger doesn't mean it is a big number.
+                        return node.bigIntegerValue().compareTo(new BigInteger(String.valueOf(Long.MAX_VALUE))) > 0;
+                    }
+                    return lm < val || (excludeEqual && lm <= val);
                 }
 
                 @Override

src/main/java/com/networknt/schema/MinimumValidator.java

@@ -74,7 +74,11 @@ public String thresholdValue() {
                 @Override
                 public boolean crossesThreshold(JsonNode node) {
                     long val = node.asLong();
-                    return node.isBigInteger() || lmin > val || (excluded && lmin >= val);
+                    if(node.isBigInteger()) {
+                        //node.isBigInteger is not trustable, the type BigInteger doesn't mean it is a big number.
+                        return node.bigIntegerValue().compareTo(new BigInteger(String.valueOf(Long.MIN_VALUE))) < 0;
+                    }
+                    return lmin > val || (excluded && lmin >= val);
                 }
 
                 @Override