Supports fail-fast when a pattern does not match. (#795)

Resolves #792

Co-authored-by: Faron Dutton <[email protected]>

Author: fdutton

src/main/java/com/networknt/schema/PatternValidator.java

@@ -35,20 +35,21 @@ public PatternValidator(String schemaPath, JsonNode schemaNode, JsonSchema paren
 
         this.pattern = Optional.ofNullable(schemaNode).filter(JsonNode::isTextual).map(JsonNode::textValue).orElse(null);
         try {
-            this.compiledPattern = RegularExpression.compile(pattern, validationContext);
+            this.compiledPattern = RegularExpression.compile(this.pattern, validationContext);
         } catch (RuntimeException e) {
             e.setStackTrace(new StackTraceElement[0]);
-            logger.error("Failed to compile pattern '{}': {}", pattern, e.getMessage());
+            logger.error("Failed to compile pattern '{}': {}", this.pattern, e.getMessage());
             throw e;
         }
         this.validationContext = validationContext;
         parseErrorCode(getValidatorType().getErrorCodeKey());
     }
 
     private boolean matches(String value) {
-        return compiledPattern.matches(value);
+        return this.compiledPattern.matches(value);
     }
 
+    @Override
     public Set<ValidationMessage> validate(JsonNode node, JsonNode rootNode, String at) {
         debug(logger, node, rootNode, at);
 
@@ -59,10 +60,13 @@ public Set<ValidationMessage> validate(JsonNode node, JsonNode rootNode, String
 
         try {
             if (!matches(node.asText())) {
-                return Collections.singleton(buildValidationMessage(at, pattern));
+                return Collections.singleton(buildValidationMessage(at, this.pattern));
             }
+        } catch (JsonSchemaException e) {
+            throw e;
         } catch (RuntimeException e) {
-            logger.error("Failed to apply pattern '{}' at {}: {}", pattern, at, e.getMessage());
+            logger.error("Failed to apply pattern '{}' at {}: {}", this.pattern, at, e.getMessage());
+            throw e;
         }
 
         return Collections.emptySet();

src/test/java/com/networknt/schema/Issue792.java

@@ -0,0 +1,40 @@
+package com.networknt.schema;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import org.junit.jupiter.api.Test;
+
+public class Issue792 {
+
+    @Test
+    void test() throws JsonProcessingException {
+        JsonSchemaFactory schemaFactory = JsonSchemaFactory.getInstance(SpecVersion.VersionFlag.V7);
+
+        String schemaDef =
+                "{\n" +
+                "  \"$schema\": \"http://json-schema.org/draft-07/schema#\",\n" +
+                "  \"$id\": \"http://some-id/\",\n" +
+                "  \"title\": \"title\",\n" +
+                "  \"type\": \"object\",\n" +
+                "  \"properties\": {\n" +
+                "    \"field\": {\n" +
+                "      \"type\": \"string\",\n" +
+                "      \"pattern\": \"^[A-Z]{2}$\"\n" +
+                "    }\n" +
+                "   }\n" +
+                "}";
+
+        SchemaValidatorsConfig config = new SchemaValidatorsConfig();
+        config.setTypeLoose(false);
+        config.setFailFast(true);
+
+        JsonSchema jsonSchema = schemaFactory.getSchema(schemaDef, config);
+        JsonNode jsonNode = new ObjectMapper().readTree("{\"field\": \"pattern-violation\"}");
+
+        //this works with 1.0.81, but not with 1.0.82+
+        assertThrows(JsonSchemaException.class, () -> jsonSchema.validate(jsonNode));
+    }
+}