If using id for subschema, validation isnt working

Author: eskabetxe

src/main/java/com/networknt/schema/BaseJsonValidator.java

@@ -20,12 +20,15 @@
 import org.apache.commons.lang.StringUtils;
 import org.slf4j.Logger;
 
+import java.net.MalformedURLException;
+import java.net.URL;
 import java.util.Set;
 
 public abstract class BaseJsonValidator implements JsonValidator {
     private String schemaPath;
     private JsonNode schemaNode;
     private JsonSchema parentSchema;
+    private JsonSchema subSchema;
     private ValidatorTypeCode validatorType;
     private String errorCode;
 
@@ -35,6 +38,7 @@ public BaseJsonValidator(String schemaPath, JsonNode schemaNode, JsonSchema pare
         this.schemaNode = schemaNode;
         this.parentSchema = parentSchema;
         this.validatorType = validatorType;
+        this.subSchema = obainSubSchemaNode(schemaNode);
     }
 
     protected String getSchemaPath() {
@@ -48,6 +52,28 @@ protected JsonNode getSchemaNode() {
     protected JsonSchema getParentSchema() {
         return parentSchema;
     }
+    
+    protected JsonSchema getSubSchema() {
+        return subSchema;
+    }
+    
+    protected boolean hasSubSchema() {
+        return subSchema != null;
+    }
+    
+    
+    protected JsonSchema obainSubSchemaNode(JsonNode schemaNode){
+    	JsonNode node = schemaNode.get("id");
+    	if(node == null) return null;
+    	
+		try {
+			JsonSchemaFactory factory = new JsonSchemaFactory();
+			URL url = new URL(node.textValue());
+			return factory.getSchema(url);
+		} catch (MalformedURLException e) {
+			return null;
+		}
+    }
 
     public Set<ValidationMessage> validate(JsonNode node) {
         return validate(node, node, AT_ROOT);

src/main/java/com/networknt/schema/JsonSchema.java

@@ -62,8 +62,9 @@ public class JsonSchema extends BaseJsonValidator {
      */
     public JsonNode getRefSchemaNode(String ref) {
         JsonSchema schema = findAncestor();
-        JsonNode node = schema.getSchemaNode();
-
+        JsonNode schemaNode = schema.getSchemaNode();
+        JsonNode node = null;
+        
         if (ref.startsWith("#/")) {
             // handle local ref
             String[] keys = ref.substring(2).split("/");
@@ -74,12 +75,12 @@ public JsonNode getRefSchemaNode(String ref) {
                 }
                 Matcher matcher = intPattern.matcher(key);
                 if (matcher.matches()) {
-                    node = node.get(Integer.parseInt(key));
+                    node = schemaNode.get(Integer.parseInt(key));
                 } else {
-                    node = node.get(key);
+                    node = schemaNode.get(key);
                 }
-                if (node == null) {
-                    break;
+                if (node == null && schema.hasSubSchema()){
+                	node = schema.getSubSchema().getRefSchemaNode(ref);
                 }
             }
         }