Collector Context changes to handle simple Objects

Author: prashanth-chaitanya

src/main/java/com/networknt/schema/AbstractCollector.java

@@ -0,0 +1,9 @@
+package com.networknt.schema;
+
+public abstract class AbstractCollector<E> implements Collector<E>{
+
+	@Override
+	public void combine(Object object) {
+		// Do nothing. This is the default Implementation.
+	}
+}

src/main/java/com/networknt/schema/Collector.java

@@ -15,8 +15,7 @@ public interface Collector<E> {
 	 * method and could be used when the same collector is used for collecting data
 	 * at multiple touch points or accumulating data at same touch point.
 	 */
-	public default void combine(Object object) {
-	};
+	public void combine(Object object);
 
 	/**
 	 * Final method called by the framework that returns the actual collected data.

src/main/java/com/networknt/schema/CollectorContext.java

@@ -33,7 +33,7 @@ public static CollectorContext getInstance() {
 	/**
 	 * 
 	 * Adds a collector with give name. Preserving this method for backward
-	 * compatibility . *
+	 * compatibility.
 	 * 
 	 * @param <E>
 	 * @param name

src/test/java/com/networknt/schema/CollectorContextTest.java

@@ -1,14 +1,20 @@
 package com.networknt.schema;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.JsonMappingException;
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.TreeSet;
+
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 
-import java.util.*;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonMappingException;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
 
 public class CollectorContextTest {
 
@@ -274,7 +280,7 @@ public Set<ValidationMessage> validate(JsonNode rootNode) {
 
 	}
 
-	private class CustomCollector implements Collector<List<String>> {
+	private class CustomCollector extends AbstractCollector<List<String>> {
 
 		List<String> returnList = new ArrayList<String>();