Update code to make pylint happy

Author: dgarros

diffsync/helpers.py

@@ -125,8 +125,8 @@ def diff_object_list(self, src: List["DiffSyncModel"], dst: List["DiffSyncModel"
 
         self.validate_objects_for_diff(combined_dict.values())
 
-        for uid in combined_dict:
-            src_obj, dst_obj = combined_dict[uid]
+        for uid, value in combined_dict.items():
+            src_obj, dst_obj = value
             diff_element = self.diff_object_pair(src_obj, dst_obj)
 
             if diff_element:

examples/01-multiple-data-sources/models.py

@@ -28,7 +28,7 @@ class Site(DiffSyncModel):
     _children = {"device": "devices"}
 
     name: str
-    devices: List = list()
+    devices: List = []
 
 
 class Device(DiffSyncModel):
@@ -42,7 +42,7 @@ class Device(DiffSyncModel):
     name: str
     site_name: Optional[str]  # note that this attribute is NOT included in _attributes
     role: Optional[str]  # note that this attribute is NOT included in _attributes
-    interfaces: List = list()
+    interfaces: List = []
 
 
 class Interface(DiffSyncModel):

examples/03-remote-system/local_adapter.py

@@ -29,7 +29,7 @@ class LocalAdapter(DiffSync):
 
     def load(self, filename=COUNTRIES_FILE):  # pylint: disable=arguments-differ
         """Load all regions and countries from a local JSON file."""
-        with open(filename, "r") as data_file:
+        with open(filename, "r") as data_file:  # pylint: disable=unspecified-encoding
             countries = json.load(data_file)
 
         # Load all regions first

examples/03-remote-system/models.py

@@ -16,7 +16,7 @@ class Region(DiffSyncModel):
 
     slug: str
     name: str
-    countries: List[str] = list()
+    countries: List[str] = []
 
 
 class Country(DiffSyncModel):

examples/04-get-update-instantiate/models.py

@@ -40,8 +40,8 @@ class Device(DiffSyncModel):
     name: str
     site_name: Optional[str]  # note that this attribute is NOT included in _attributes
     role: Optional[str]  # note that this attribute is NOT included in _attributes
-    interfaces: List = list()
-    sites: List = list()
+    interfaces: List = []
+    sites: List = []
 
 
 class Interface(DiffSyncModel):

examples/05-nautobot-peeringdb/adapter_nautobot.py

@@ -46,7 +46,7 @@ def update(self, attrs):
             data["description"] = attrs["description"]
         if "parent_name" in attrs:
             if attrs["parent_name"]:
-                data["parent"] = str(self.get(self.region, attrs["parent_name"]).pk)
+                data["parent"] = str(self.diffsync.get(self.diffsync.region, attrs["parent_name"]).pk)
             else:
                 data["parent"] = None
         self.diffsync.patch(f"/api/dcim/regions/{self.pk}/", data)

tasks.py

@@ -27,7 +27,7 @@
 
 def project_ver():
     """Find version from pyproject.toml to use for docker image tagging."""
-    with open("pyproject.toml") as file:
+    with open("pyproject.toml") as file:  # pylint: disable=unspecified-encoding
         return toml.load(file)["tool"]["poetry"].get("version", "latest")
 
 

tests/unit/conftest.py

@@ -73,7 +73,7 @@ class Site(DiffSyncModel):
     _children = {"device": "devices"}
 
     name: str
-    devices: List = list()
+    devices: List = []
 
 
 @pytest.fixture
@@ -100,7 +100,7 @@ class Device(DiffSyncModel):
     name: str
     site_name: Optional[str]  # note this is not included in _attributes
     role: str
-    interfaces: List = list()
+    interfaces: List = []
 
 
 @pytest.fixture
@@ -189,7 +189,7 @@ class SiteA(Site):
 
     _children = {"device": "devices", "person": "people"}
 
-    people: List = list()
+    people: List = []
 
 
 class DeviceA(Device):
@@ -305,15 +305,15 @@ class SiteB(Site):
 
     _children = {"device": "devices", "place": "places"}
 
-    places: List = list()
+    places: List = []
 
 
 class DeviceB(Device):
     """Extend Device with a `vlans` list."""
 
     _attributes = ("role", "vlans")
 
-    vlans: List = list()
+    vlans: List = []
 
 
 class PlaceB(DiffSyncModel):

tests/unit/test_diff.py

@@ -25,10 +25,10 @@ def test_diff_empty():
     """Test the basic functionality of the Diff class when initialized and empty."""
     diff = Diff()
 
-    assert diff.children == {}
-    assert list(diff.groups()) == []
+    assert not diff.children
+    assert not list(diff.groups())
     assert not diff.has_diffs()
-    assert list(diff.get_children()) == []
+    assert not list(diff.get_children())
 
 
 def test_diff_summary_with_no_diffs():
@@ -46,7 +46,7 @@ def test_diff_str_with_no_diffs():
 def test_diff_dict_with_no_diffs():
     diff = Diff()
 
-    assert diff.dict() == {}
+    assert not diff.dict()
 
 
 def test_diff_len_with_no_diffs():

tests/unit/test_diff_element.py

@@ -29,7 +29,7 @@ def test_diff_element_empty():
     assert element.dest_name == "dest"
     assert element.source_attrs is None
     assert element.dest_attrs is None
-    assert list(element.get_children()) == []
+    assert not list(element.get_children())
     assert not element.has_diffs()
     assert not element.has_diffs(include_children=True)
     assert not element.has_diffs(include_children=False)
@@ -54,7 +54,7 @@ def test_diff_element_str_with_no_diffs():
 
 def test_diff_element_dict_with_no_diffs():
     element = DiffElement("interface", "eth0", {"device_name": "device1", "name": "eth0"})
-    assert element.dict() == {}
+    assert not element.dict()
 
 
 def test_diff_element_len_with_no_diffs():