Fix NXOS 7.x and support VFC interfaces (#2180)

Author: mjbear

ntc_templates/templates/cisco_nxos_show_interface.textfsm

@@ -63,7 +63,7 @@ Start
   ^admin\s+state\s+is\s+${ADMIN_STATE}
   ^\s+Hardware(:|\s+is)\s+${HARDWARE_TYPE},\s+address(:|\s+is)\s+${MAC_ADDRESS}(.*bia\s+${BIA})*
   ^\s+Hardware(:|\s+is)\s+${HARDWARE_TYPE}
-  ^\s+Description:\s+${DESCRIPTION}\s*$$
+  ^\s+(Port\s+)?[Dd]escription(:|\s+is)\s+${DESCRIPTION}\s*$$
   ^\s+Internet\s+Address\s+is\s+${IP_ADDRESS}\/${PREFIX_LENGTH}
   ^\s+Port\s+mode\s+is\s+${MODE}
   ^\s+${DUPLEX},\s+${SPEED}(,\s+media\s+type\s+is\s+${MEDIA_TYPE})?\s*$$
@@ -77,8 +77,8 @@ Start
   ^\s+${OUTPUT_PACKETS}\s+packets\s+output\s+\d+\s+bytes\s+${UNDERRUN}\s+underruns\s*$$
   ^\s+input:\s+${INPUT_PACKETS}\s+pkts,\s+\d+\s+bytes\s+-\s+output:\s+${OUTPUT_PACKETS}\s+pkts,\s+\d+\s+bytes\s*$$
   ^\s+Last\s+link\s+flapped\s+${LAST_LINK_FLAPPED}\s*$$
-  ^\s+\d+\s+(second|minute)s?\s+input\s+rate\s+${BANDWIDTH_INPUT_RATE}\s+bits/sec,\s+${PACKET_INPUT_RATE}\s+packets/sec
-  ^\s+\d+\s+(second|minute)s?\s+output\s+rate\s+${BANDWIDTH_OUTPUT_RATE}\s+bits/sec,\s+${PACKET_OUTPUT_RATE}\s+packets/sec
+  ^\s+\d+\s+(second|minute)s?\s+input\s+rate\s+${BANDWIDTH_INPUT_RATE}\s+bits/sec(,\s+${PACKET_INPUT_RATE}\s+packets/sec)?
+  ^\s+\d+\s+(second|minute)s?\s+output\s+rate\s+${BANDWIDTH_OUTPUT_RATE}\s+bits/sec(,\s+${PACKET_OUTPUT_RATE}\s+packets/sec)?
   # RX
   ^\s+${INPUT_ERRORS}\s+input\s+errors?\s+${SHORT_FRAME}\s+short\s+frame\s+${OVERRUN}\s+overrun\s+${UNDERRUN}\s+underrun\s+${IGNORED}\s+ignored\s*$$
   ^\s+${INPUT_ERRORS}\s+input\s+errors\s+${SHORT_FRAME}\s+frame\s+${OVERRUN}\s+overrun\s+\d+\s+fifo\s*$$
@@ -112,9 +112,9 @@ Start
   ^\s+admin\s+fec\s+state\s+is\s+\S+,\s+oper\s+fec\s+state\s+is\s+\S+\s*$$
   ^\s+Keepalive\s+
   ^\s+ARP\s+type:\s+\S+\s*$$
-  ^\s+\d+\s+broadcast\s+packets\s+\d+\s+bytes\s*$$
+  ^\s+\d+\s+broadcast\s+packets\s+\d+\s+(bytes|packets/sec)\s*$$
   ^\s+ucast:\s+\d+\s+pkts,\s+\d+\s+bytes(\s+-\s+mcast:\s+\d+\s+pkts,\s+\d+\s+bytes)?\s*$$
-  ^\s+\d+\s+unicast\s+packets\s+\d+\s+multicast\s+packets\s+\d+\s+broadcast\s+packets\s*$$
+  ^\s+\d+\s+unicast\s+packets\s+\d+\s+multicast\s+packets(\s+\d+\s+broadcast\s+packets)?\s*$$
   ^\s+(Ha\s+)?input\s+rate\s+\S+\s+\w?bps,\s+\S+\s+\w?pps;\s+output\s+rate\s+\S+\s+\w?bps,\s+\S+\s+\w?pps\s*$$
   ^\s+Members\s+in\s+this\s+channel:\s+
   ^\s+No\s+members
@@ -125,4 +125,9 @@ Start
   ^\s+Input\s+flow-control\s+is\s+\S+,\s+Port\s+mode\s+is\s+\S+\s*$$
   ^\s+\d+\s+multicast\s+frames\s+\d+\s+compressed\s*$$
   ^\s+\d+\s+out_carrier_errors\s*$$
+  ^\s+VFC\s+not\s+bound
+  ^\s+Port\s+(WWN|vsan)
+  ^\s+Admin\s+port\s+mode
+  ^\s+snmp\s+link\s+state
+  ^\s+Current\s+counters\s+not\s+available
   ^. -> Error

tests/cisco_nxos/show_interface/cisco_nxos_show_interface10.raw

@@ -0,0 +1,29 @@
+mgmt0 is up
+  Hardware: GigabitEthernet, address: 547f.ee64.6681 (bia 547f.ee64.6681)
+  Internet Address is 192.168.255.253/30
+  MTU 1500 bytes, BW 1000000 Kbit, DLY 10 usec
+  reliability 255/255, txload 1/255, rxload 1/255
+  Encapsulation ARPA
+  full-duplex, 1000 Mb/s
+  EtherType is 0x0000 
+  Rx
+    58109478 input packets 5334957465 bytes
+    55337598 unicast packets 2771874 multicast packets
+    6 broadcast packets  0 packets/sec
+    1 minute input rate 792 bits/sec
+  Tx
+    58088428 output packets 5318342661 bytes
+    55316528 unicast packets 2771853 multicast packets
+    47 broadcast packets  0 packets/sec
+    1 minute output rate 776 bits/sec
+vfc248 is down (Error Disabled - VFC not bound)
+    VFC not bound 
+    Port description is PILLAR_A1
+    Hardware is Ethernet 
+    Port WWN is 20:f7:54:7f:ee:64:66:bf
+    Admin port mode is F, trunk mode is on
+    snmp link state traps are enabled
+    Port vsan is 1
+    1 minute input rate 0 bits/sec, 0 bytes/sec, 0 frames/sec
+    1 minute output rate 0 bits/sec, 0 bytes/sec, 0 frames/sec
+    Current counters not available

tests/cisco_nxos/show_interface/cisco_nxos_show_interface10.yml

@@ -0,0 +1,110 @@
+---
+parsed_sample:
+  - admin_state: ""
+    babble: ""
+    bad_etype_drop: ""
+    bad_proto_drop: ""
+    bandwidth: "1000000 Kbit"
+    bandwidth_input_rate: "792"
+    bandwidth_output_rate: "776"
+    bia: "547f.ee64.6681"
+    collisions: ""
+    crc: ""
+    deferred: ""
+    delay: "10 usec"
+    description: ""
+    dribble: ""
+    duplex: "full-duplex"
+    encapsulation: "ARPA"
+    giants: ""
+    hardware_type: "GigabitEthernet"
+    ignored: ""
+    input_discards: ""
+    input_errors: ""
+    input_packets: "58109478"
+    interface: "mgmt0"
+    interface_down_drop: ""
+    ip_address: "192.168.255.253"
+    last_link_flapped: ""
+    late_collisions: ""
+    link_status: "up"
+    lost_carrier: ""
+    mac_address: "547f.ee64.6681"
+    media_type: ""
+    mode: ""
+    mtu: "1500"
+    no_buffer: ""
+    no_carrier: ""
+    output_discards: ""
+    output_errors: ""
+    output_packets: "58088428"
+    overrun: ""
+    packet_input_rate: ""
+    packet_output_rate: ""
+    prefix_length: "30"
+    runts: ""
+    rx_jumbo_packets: ""
+    rx_pause: ""
+    short_frame: ""
+    speed: "1000 Mb/s"
+    stomped_crc: ""
+    storm_suppression_bytes: ""
+    tx_jumbo_packets: ""
+    tx_pause: ""
+    underrun: ""
+    vlan_id: ""
+    watchdog: ""
+  - admin_state: ""
+    babble: ""
+    bad_etype_drop: ""
+    bad_proto_drop: ""
+    bandwidth: ""
+    bandwidth_input_rate: "0"
+    bandwidth_output_rate: "0"
+    bia: ""
+    collisions: ""
+    crc: ""
+    deferred: ""
+    delay: ""
+    description: "PILLAR_A1"
+    dribble: ""
+    duplex: ""
+    encapsulation: ""
+    giants: ""
+    hardware_type: "Ethernet "
+    ignored: ""
+    input_discards: ""
+    input_errors: ""
+    input_packets: ""
+    interface: "vfc248"
+    interface_down_drop: ""
+    ip_address: ""
+    last_link_flapped: ""
+    late_collisions: ""
+    link_status: "down (Error Disabled - VFC not bound)"
+    lost_carrier: ""
+    mac_address: ""
+    media_type: ""
+    mode: ""
+    mtu: ""
+    no_buffer: ""
+    no_carrier: ""
+    output_discards: ""
+    output_errors: ""
+    output_packets: ""
+    overrun: ""
+    packet_input_rate: ""
+    packet_output_rate: ""
+    prefix_length: ""
+    runts: ""
+    rx_jumbo_packets: ""
+    rx_pause: ""
+    short_frame: ""
+    speed: ""
+    stomped_crc: ""
+    storm_suppression_bytes: ""
+    tx_jumbo_packets: ""
+    tx_pause: ""
+    underrun: ""
+    vlan_id: ""
+    watchdog: ""