BUG: NUT-Monitor 'was_online' should be a class variable.

[xxxajk]

https://github.com/networkupstools/nut/blob/master/scripts/python/app/NUT-Monitor-py3qt5.in#L900

Because was_online is not a class variable, and always reset to True, while on battery, gui_status_notification spams desktop with notifications.

Fix:
Move line 900 to line 887
change was_online to self.was_online on lines 929, 931, 935, 938

The same is also true for the other variants.

[jimklimov]

Seems to make sense. Can you port a PR please?

But cursorily looking, I think it should be a class variable for ups instances, no? Can you check if it multiplexes possibly several monitored UPSes there, or deals with one overall state "we are 100% powered or not"?

[xxxajk]

Unfortunately I only have 1 UPS, and I am on Qt5/py3 I can do a PR later today for all three flavors.
There are a few other problems too, but I will make a new bug for that.
Also nut monitor seems to be single instance...

[jimklimov]

Sounds great, thanks!

Note you can set up a dummy-ups locally to check behavior with several UPSes.

[xxxajk]

It looks like for Qt6 this was fixed by using the parent class. Since I do not see a way to connect to more than one ups at the same time, does that even make sense?
While I don't see any harm in doing that, other than double back references, does the Qt6 version connect to more than one ups at a time?

[jimklimov]

Aha, ok - I guess I was confused by my memory that in the beginning it asks for a device to monitor (via dropdown). After that it looks at one.

[xxxajk]

PR submitted.
#3176