-
Notifications
You must be signed in to change notification settings - Fork 33
Replace Salesforce KB links with local KB links in Activity Monitor docs #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request ReviewSummaryThis PR replaces broken Salesforce KB links with local KB article references in Activity Monitor upgrade documentation for versions 7.1 and 8.0. The changes are focused, well-documented, and improve the user experience by pointing to accessible internal documentation. ✅ Strengths
|
paul-sh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although those new links do not open for me, I suspect they will after integration
- Updated 2 files in activitymonitor/7.1 and activitymonitor/8.0 - Replaced helpcenter.netwrix.com Salesforce bundle links with relative /docs/kb/ paths - All links validated and working in dev server (HTTP 200) - Links now point to /docs/kb/activitymonitor/netwrix_activity_monitor_(nam)_7.0_paths Part of effort to replace 142 broken Salesforce KB references across product docs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
9d1a0cd to
d274ebd
Compare
Pull Request ReviewSummaryThis PR successfully replaces broken external Salesforce KB links with local KB article references in Activity Monitor documentation. The changes are well-scoped and improve documentation maintainability. ✅ Strengths1. Code Quality & Best Practices
2. Documentation Quality
3. Maintainability Benefits
🔍 Observations & Considerations1. Version Accuracy ConsiderationThe KB article is titled "NAM 7.0 Paths" but is being referenced from both:
Question: Does the 7.0 paths article apply to versions 7.1 and 8.0, or should there be version-specific KB articles? The content describes path changes "from 6.0" to 7.0, so this might need clarification if paths changed again in 7.1 or 8.0. Recommendation: Consider either:
2. Complete Migration CoverageGood job! Grep search confirms no other Salesforce KB links remain in the Activity Monitor documentation. 3. Link Text ConsistencyMinor observation: The link text differs between the two files:
Both link to the same 7.0 paths article. Consider standardizing the link text if they reference the same resource. 🧪 Testing NotesThe PR description indicates:
Additional testing recommendations:
🔒 Security & Performance
📋 Test CoverageN/A - Documentation changes don't require automated tests, but manual verification of link functionality is recommended. 🎯 Final RecommendationAPPROVE with minor suggestions for consideration. This is a solid improvement that:
The version-specific question raised above is worth discussing but shouldn't block this PR unless there are known differences in paths between versions 7.0, 7.1, and 8.0. Review conducted via automated analysis of PR #348 |
Pull Request ReviewSummaryThis PR replaces broken Salesforce KB links with local KB article references in Activity Monitor documentation (versions 7.1 and 8.0). The changes are straightforward and improve documentation maintainability. ✅ Strengths
|
Summary
Replaces broken Salesforce KB links with local KB article references in Activity Monitor documentation.
Changes
/docs/kb/activitymonitor/article-nameExample Fix
Before:
After:
Testing
✅ KB article exists in
/docs/kb/activitymonitor/✅ Link uses correct Docusaurus format (no .md extension)
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]