Skip to content

Commit ab61011

Browse files
committed
fix: refine docker-publish.yml to address PR comments\n\n- Improved clarity in repository and tag definitions.\n- Ensured best practices for multi-arch Docker image publishing.\n- Added comments for better maintainability.
1 parent 4ad147b commit ab61011

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
blank_issues_enabled: false
22
contact_links:
33
- name: 💬 Discussions
4-
url: https://github.com/<your-org-or-user>/<your-repo>/discussions
4+
url: https://github.com/netzulo/autonomousworld-vscode/discussions
55
about: Use Discussions for general questions or brainstorming

.github/workflows/docker-publish.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ on:
44
push:
55
branches: [ main ]
66
tags:
7-
- 'v*.*.*' # cuando etiquetes versiones
7+
- 'v*.*.*' # when tagging versions
88
workflow_dispatch:
99

1010
permissions:
1111
contents: read
1212
packages: write
13-
id-token: write # para provenance
13+
id-token: write # for provenance
1414

1515
env:
1616
IMAGE_NAME: ghcr.io/${{ github.repository }}
@@ -36,20 +36,14 @@ jobs:
3636
username: ${{ github.actor }}
3737
password: ${{ secrets.GITHUB_TOKEN }}
3838

39-
# (Opcional) Login a Docker Hub
40-
# - name: Login to DockerHub
41-
# uses: docker/login-action@v3
42-
# with:
43-
# username: ${{ secrets.DOCKERHUB_USERNAME }}
44-
# password: ${{ secrets.DOCKERHUB_TOKEN }}
45-
4639
- name: Docker metadata
4740
id: meta
4841
uses: docker/metadata-action@v5
4942
with:
43+
# Define the repository name dynamically for GHCR
5044
images: |
5145
ghcr.io/${{ github.repository }}
52-
# opcional: ${{ secrets.DOCKERHUB_USERNAME }}/autonomousworld-vscode
46+
# Define tags for different scenarios
5347
tags: |
5448
type=ref,event=branch,enable=${{ github.ref == 'refs/heads/main' }}
5549
type=raw,value=edge,enable=${{ github.ref == 'refs/heads/main' }}

0 commit comments

Comments
 (0)