[qacode] fix for issue #256 (#257)

* [qacode] fix for issue #256

+ delete control_group
+ delete tests for control_group
+ update CHANGELOG + USAGE
* [qacode] add tests to logger_manager

Author: netzulo

CHANGELOG.md

@@ -24,7 +24,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Now get_tag update self property
 
 ### Removed
-
+- Deleted ControlGroup + tests #256
 
 ## [v0.6.0] - 2019-03-18
 

USAGE.rst

@@ -152,12 +152,6 @@ ControlForm
   + method **dropdown_deselect** : The Select class only works with tags which have select tags
   + method **dropdown_deselect_all** : The Select class only works with tags which have select tags with multiple="multiple" attribute.
 
-ControlGroup
-~~~~~~~~~~~~
-
-+ Param **on_instance_group** : by default it's disabled, at enable raises when strict_rules type warning logs message with 'hight severity' or when type error log messages with 'medium or more severity'
-+ Param **group** : allow to track all ControlBase elements using `elements` (*instances of WebElement*) and `group` (*instances of ControlBase*) properties 
-
 Pages
 -----
 

qacode/configs/settings.json

@@ -82,7 +82,9 @@
               { "name": "lst_ordered", "selector": "ol:nth-child(1)"},
               { "name": "lst_ordered_child", "selector": "li"},
               { "name": "dd_menu_data", "selector": "#ddData"},
-              { "name": "dd_menu_data_lists", "selector": "a[href='/qacode/data/lists']"}
+              { "name": "dd_menu_data_lists", "selector": "a[href='/qacode/data/lists']"},
+              { "name": "tbl_ok", "selector": "#tblOk"},
+              { "name": "tbl_html5_ok", "selector": "#tblHtml5Ok"}
             ]
           },
           { "name": "qacode_inputs",

qacode/core/webs/controls/__init__.py

@@ -4,7 +4,6 @@
 
 from qacode.core.webs.controls import control_base
 from qacode.core.webs.controls import control_form
-from qacode.core.webs.controls import control_group
 
 
-__all__ = ['control_base', 'control_form', 'control_group']
+__all__ = ['control_base', 'control_form']

qacode/core/webs/controls/control_group.py

@@ -7,7 +7,6 @@
 from qacode.core.exceptions.page_exception import PageException
 from qacode.core.webs.controls.control_base import ControlBase
 from qacode.core.webs.controls.control_form import ControlForm
-from qacode.core.webs.controls.control_group import ControlGroup
 
 from selenium.webdriver.common.by import By
 
@@ -97,7 +96,6 @@ def _load(self, settings=None):
                 control = {
                     'ControlBase': ControlBase,
                     'ControlForm': ControlForm,
-                    'ControlGroup': ControlGroup,
                 }[instance](self.bot, **cfg_control)
             except KeyError:
                 self.log.debug(("Bad instance name selected for "
@@ -152,7 +150,7 @@ def get_elements(self, config_controls):
             instance = config_control.get("instance")
             control = None
             try:
-                control_types = (ControlBase, ControlForm, ControlGroup)
+                control_types = (ControlBase, ControlForm)
                 if isinstance(instance, control_types):
                     controls.append(control)
                 else:

qacode/core/webs/pages/page_base.py

@@ -18,12 +18,3 @@ Class: ControlForm
     :show-inheritance:
  .. autoclass::  qacode.core.webs.controls.control_form.ControlForm
     :members:
-
-Class: ControlGroup
--------------------
- .. automodule:: qacode.core.webs.controls.control_group
-    :members:
-    :undoc-members:
-    :show-inheritance:
- .. autoclass::  qacode.core.webs.controls.control_group.ControlGroup
-    :members:

source-docs/source/controls.rst

@@ -92,8 +92,6 @@ def test_config_tests_keys(self, key_name):
                 key_value.get('web_controls').get('control_base'), bool)
             self.assert_is_instance(
                 key_value.get('web_controls').get('control_form'), bool)
-            self.assert_is_instance(
-                key_value.get('web_controls').get('control_group'), bool)
             self.assert_is_instance(
                 key_value.get('web_pages'), bool)
             self.assert_is_instance(

tests/000_unitaries/suite_001_config.py

@@ -4,6 +4,7 @@
 
 import logging
 import pytest
+from qacode.core.loggers.logger_manager import LoggerManager
 from qacode.core.testing.test_info import TestInfoBase
 from qatestlink.core.testlink_manager import TLManager
 from qautils.files import settings
@@ -43,3 +44,18 @@ def test_002_log_levels(self, log_level):
             self.log.error(msg)
         if log_level == 'CRITICAL':
             self.log.critical(msg)
+
+    def test_loggermanager_notlogpath(self):
+        """Testcase: test_loggermanager_notlogpath"""
+        with pytest.raises(Exception):
+            LoggerManager(log_path=None)
+
+    def test_loggermanager_notlogname(self):
+        """Testcase: test_loggermanager_notlogname"""
+        with pytest.raises(Exception):
+            LoggerManager(log_name=None)
+
+    def test_loggermanager_allflagsfalse(self):
+        """Testcase: test_loggermanager_allflagsfalse"""
+        with pytest.raises(Exception):
+            LoggerManager(is_output_console=False, is_output_file=False)