[qacode] fix for issue #305 (#306)

* [qacode] fix for issue #305

* [qacode] fix flake

* [qacode] fix docs env for tox

* [qacode] fix CIs

* [qacode] fix appveyor

* [qacode] appveyor, please... i need you

* [qacode] windows, i hate you, sometimes

Author: netzulo

.circleci/config.yml

@@ -36,6 +36,7 @@ jobs:
           name: Before Tests
           command: |
             ./cc-test-reporter before-build
+            touch logs/qacode.log
 
       - run:
           name: Run Tests

.travis.yml

@@ -29,6 +29,7 @@ install:
 - pip install tox
 - python setup.py clean build install sdist
 script:
+- touch logs/qacode.log
 - tox -e "flake8"
 - tox -e "$TOXENV"
 - pip freeze

CHANGELOG.md

@@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ### Removed
 
+- [BP] remove ControlForm and StrictRules + tests #305
+
 
 ## [v0.6.3] - 2020-01-29
 

USAGE.rst

@@ -145,27 +145,6 @@ Example of usage
     txt_password.type_text('SuperSecretPassword!', clear=True)
     btn_login.click()
 
-
-
-ControlForm
-~~~~~~~~~~~
-
-+ Param **rules** : Allow to add strict_rules configuration to laod StrictRule class for each rule ( example: ``strict_rule = StrictRule('my_named_rule', StrictType.TAG, StrictSeverity.HIGHT)`` )
-
-- Methods for **ControlForm**
-
-  + method **__load__** : Load properties from settings dict. Some elements need to search False to be search at future
-  + method **__settings_parse__** : Allow to parse settings obtaining from super and applying self instance behaviour
-  + method **__rules_parse__** : Validate rules for each type of StricRule
-  + method **__rules_apply__** : Allow to apply rules using self WebElement
-  + method **__rules_apply_tag__** : Apply Tag based on StictType.TAG enum
-  + method **__check_reload__** : Allow to check before methods calls to ensure if it's neccessary reload element properties
-  + method **reload** : Reload 'self.settings' property:dict and call to instance logic with new configuration
-
-- Properties for **ControlForm**
-
-  + property **rules** : `GET`
-
 ControlDropdown
 ~~~~~~~~~~~~~~~
 

appveyor.yml

@@ -65,6 +65,7 @@ install:
   - "pip install tox"
 
 test_script:
+  - "echo hello > logs\\qacode.log"
   - "tox -e flake8"
   - "tox -e %TOXENV%"
 

logs/qacode.log

@@ -7,7 +7,6 @@
 from qacode.core.webs import html_attrs
 from qacode.core.webs import html_tags
 from qacode.core.webs import pages
-from qacode.core.webs import strict_rules
 
 
 __all__ = [
@@ -16,5 +15,4 @@
     'html_attrs',
     'html_tags',
     'pages',
-    'strict_rules'
 ]

qacode/core/webs/__init__.py

@@ -4,9 +4,8 @@
 
 from qacode.core.webs.controls import control_base
 from qacode.core.webs.controls import control_dropdown
-from qacode.core.webs.controls import control_form
 from qacode.core.webs.controls import control_table
 
 
 __all__ = [
-    'control_base', 'control_dropdown', 'control_form', 'control_table']
+    'control_base', 'control_dropdown', 'control_table']

qacode/core/webs/controls/__init__.py

@@ -40,7 +40,6 @@ def __init__(self, bot, **kwargs):
         self._on_instance_search = None
         self._auto_reload = None
         # __search__, step 2
-        self._tag = None
         self._text = None
         self._is_displayed = None
         self._is_enabled = None
@@ -127,7 +126,6 @@ def __search__(self):
             self.bot.log.debug(MSG.CB_SEARCH_FOUND)
         # Step 2 load minimal properties defined by qacode
         self.bot.log.debug(MSG.CB_PROP_LOADING)
-        self._tag = self.get_tag()
         self._text = self.get_text()
         self._is_displayed = nav.ele_is_displayed(self.element)
         self._is_enabled = nav.ele_is_enabled(self.element)
@@ -200,15 +198,6 @@ def find_children(self, selector, locator=By.CSS_SELECTOR):
             self.bot.log.debug(MSG.CB_FINDCHILD_LOADED)
         return ctls
 
-    def get_tag(self):
-        """Returns tag_name from Webelement"""
-        self.bot.log.debug(MSG.CB_GETTAG_LOADING)
-        self.__check_reload__()
-        tag = self.bot.navigation.ele_tag(self.element)
-        self.bot.log.debug(MSG.CB_GETTAG_LOADED.format(tag))
-        self._tag = tag
-        return tag
-
     def type_text(self, text, clear=False):
         """Type text on input element
 
@@ -418,14 +407,13 @@ def __repr__(self):
         return ("{}: name={}, "
                 "bot.browser={}, bot.mode={} \n"
                 "settings={} \n"
-                "tag={}, is_displayed={}, "
+                "is_displayed={}, "
                 "is_enabled={}, is_selected={}").format(
             self.__class__.__name__,
             self.name,
             self.bot.settings.get('browser'),
             self.bot.settings.get('mode'),
             self.settings,
-            self.tag,
             self.is_displayed,
             self.is_enabled,
             self.is_selected)
@@ -505,8 +493,12 @@ def auto_reload(self):
 
     @property
     def tag(self):
-        """GET for _tag attribute"""
-        return self._tag
+        """GET for _tag attribute. Returns from Webelement directly"""
+        self.bot.log.debug(MSG.CB_GETTAG_LOADING)
+        self.__check_reload__()
+        tag = self.bot.navigation.ele_tag(self.element)
+        self.bot.log.debug(MSG.CB_GETTAG_LOADED.format(tag))
+        return tag
 
     @property
     def text(self):

qacode/core/webs/controls/control_base.py

@@ -1,34 +1,26 @@
 # -*- coding: utf-8 -*-
-"""Package module qacode.core.webs.control_form"""
+"""Package module qacode.core.webs.control_dropdown"""
 
 
 from qacode.core.exceptions.control_exception import ControlException
 from qacode.core.loggers import logger_messages as MSG
-from qacode.core.webs.controls.control_form import ControlForm
+from qacode.core.webs.controls.control_base import ControlBase
 from selenium.webdriver.support.ui import Select
 
 
-class ControlDropdown(ControlForm):
+class ControlDropdown(ControlBase):
     """TODO: doc class"""
 
     def __init__(self, bot, **kwargs):
-        """Instance of ControlForm. Load properties from settings dict.
+        """Instance of ControlDropdown. Load properties from settings dict.
             Some elements need to search False to be search at future
         """
-        rules = kwargs.get("rules") or []
-        if not bool(rules):
-            rules.append(
-                {"tag": "select", "type": "tag", "severity": "hight"})
-            kwargs.update({"rules": rules})
         super(ControlDropdown, self).__init__(bot, **kwargs)
         self._dropdown = None
 
     def __load__(self, **kwargs):
         """Allow to reinstance control properties"""
         super(ControlDropdown, self).__load__(**kwargs)
-        if self.tag is not None and self.tag != "select":
-            self.bot.log.error(MSG.CDD_BADTAG)
-            raise ControlException(MSG.CDD_BADTAG, info_bot=self._info_bot)
         if self._on_instance_search:
             self._dropdown = Select(self._element)