https://github.com/neu-rah/ArduinoMenu/issues/178

API is already differentiating cursors, implementing specializations on 
u8g2 driver to account for specific font margins
TODO: check if we really need Y adjust on cursor

Author: neu-rah

examples/lolin32/lolin32/lolin32.ino

@@ -33,8 +33,8 @@ using namespace Menu;
 #define U8_Width 128
 #define U8_Height 64
 #define USE_HWI2C
-#define fontMarginX 1
-#define fontMarginY 1
+#define fontMarginX 2
+#define fontMarginY 2
 // U8G2_SSD1306_128X64_NONAME_F_HW_I2C u8g2(U8G2_R0, U8X8_PIN_NONE, SCL, SDA);
 U8G2_SSD1306_128X64_VCOMH0_F_HW_I2C u8g2(U8G2_R0, U8X8_PIN_NONE, SCL, SDA);//allow contrast change
 // U8G2_SSD1306_128X64_NONAME_1_HW_I2C u8g2(U8G2_R0, U8X8_PIN_NONE, SCL, SDA);

library.properties

@@ -1,5 +1,5 @@
 name=ArduinoMenu library
-version=4.17.14
+version=4.17.15
 author=Rui Azevedo, [email protected]
 maintainer=neu-rah, [email protected]
 sentence=Generic menu/interactivity system

src/items.cpp

@@ -215,11 +215,11 @@ Used textField::printTo(navRoot &root,bool sel,menuOut& out, idx_t idx,idx_t len
     if (at==cursor&&editing) {
       // MENU_DEBUG_OUT<<"idx:"<<idx<<" line:"<<line<<" at:"<<at<<" l:"<<l<<endl;
       // c=l+1;
-      l+=out.startCursor(root,l,line,charEdit);//draw textual cursor or color code start
+      l+=out.startCursor(root,l,line,charEdit);//draw text cursor or color code start
       out.write(buffer()[at++]);//draw focused character
-      l+=out.endCursor(root,l,line,charEdit);//draw textual cursor or color code end
+      l+=out.endCursor(root,l,line,charEdit);//draw text cursor or color code end
     } else out.write(buffer()[at++]);
-  out.editCursor(root,c+cursor,line,editing,charEdit);//reposition a non text cursor
+  out.editCursor(root,c+cursor,line,editing,charEdit);//reposition a gfx cursor
   #ifdef MENU_FMT_WRAPS
     out.fmtEnd(*this,menuOut::fmtTextField,root.node(),idx);
   #endif

src/menuIO/u8g2Out.h

@@ -97,16 +97,43 @@ namespace Menu {
 			}
 
 			void setCursor(idx_t x,idx_t y,idx_t panelNr=0) override {
+				// _trace(Serial<<"setCursor"<<endl);
 				const panel p=panels[panelNr];
 				gfx.tx = (p.x+x)*resX+fontMarginX + offsetX;
 				gfx.ty = (p.y+y+1)*resY-fontMarginY + offsetY;
 			}
 
+			idx_t startCursor(navRoot& root,idx_t x,idx_t y,bool charEdit,idx_t panelNr) override {
+			  if (charEdit) {
+			    // rect(panelNr,  x-1,  y, 1, 1, bgColor, false, enabledStatus, false);
+					const panel p=panels[panelNr];
+					gfx.drawBox((p.x+x)*resX + offsetX +fontMarginX,(p.y+y)*resY+ offsetY -fontMarginY,resX,resY);
+			    setColor(fgColor,false,enabledStatus,false);
+			  }/* else
+			    box(panelNr,  x,  y, 1, 1, bgColor, false, enabledStatus, false);*/
+			  return 0;
+			}
+
+			// idx_t endCursor(navRoot& root,idx_t x,idx_t y,bool charEdit,idx_t panelNr) override {
+			//   setColor(fgColor,true,enabledStatus,true);return 0;
+			// }
+
+      idx_t editCursor(navRoot& root,idx_t x,idx_t y,bool editing,bool charEdit,idx_t panelNr=0) override {
+			  if (editing) {
+					_trace(Serial<<"editCursor"<<endl);
+					// box(panelNr,x-1,y);
+					const panel p=panels[panelNr];
+					gfx.drawFrame((x+p.x-1)*resX + offsetX + fontMarginX-1,(p.y+y)*resY + offsetY - fontMarginY+2,resX+1 ,resY);
+				}
+			  return 0;
+			}
+
 			void drawCursor(idx_t ln,bool selected,status stat,bool edit=false,idx_t panelNr=0) override {
+				// _trace(Serial<<"drawCursor"<<endl);
 				const panel p=panels[panelNr];
 				// gfxOut::drawCursor(ln,selected,stat);
 				setColor(cursorColor,selected,stat);
-				gfx.drawFrame(p.x*resX + offsetX /*+ fontMarginX*/,(p.y+ln)*resY + offsetY /*- fontMarginY*/,maxX()*resX ,resY);
+				gfx.drawFrame(p.x*resX + offsetX /*+ fontMarginX*/,(p.y+ln)*resY + offsetY /*+ fontMarginY*/,maxX()*resX ,resY);
 			}
 			idx_t printRaw(const char* at,idx_t len) override {
 				trace(Serial<<"u8g2Out::printRaw"<<endl);