Additional fixes for possible memory leak and TS issues.

Author: garrettmflynn

packages/core/build.ts

@@ -341,12 +341,9 @@ export async function buildApp(
 
       hooks.emit({ type: 'build:electron:complete' })
     } else if (isMobileBuild) {
-      const mobileOpts = { target, outDir }
+      const mobileOpts = { target: target as 'ios' | 'android', outDir }
 
-      // @ts-expect-error
       await mobile.init(mobileOpts, resolvedConfig)
-
-      // @ts-expect-error
       await mobile.open(mobileOpts, resolvedConfig)
     }
 

packages/core/utils/assets.ts

@@ -363,9 +363,11 @@ export const getServiceAssets = (
 
   for (const name of servicesToBuild) {
 
-    const resolvedService = resolvedServices[name] as ResolvedService
+    const resolvedService = resolvedServices[name] as ResolvedService & {
+      __src?: string
+      __autobuild?: boolean
+    }
 
-    // @ts-ignore
     const { build, base, filepath, __src, __autobuild } = resolvedService
 
     const allowCompilation = !(dev && __autobuild)

packages/core/utils/processes.js

@@ -42,18 +42,27 @@ export const spawnProcess = (command, args, { env = {}, opts = {}, cwd, label }
 
     children[proc.pid] = proc
 
+    // Cleanup function to remove process and listeners
+    const cleanup = (res) => {
+      delete children[proc.pid]
+      // Remove all listeners to prevent memory leaks
+      proc.removeAllListeners()
+      if (proc.stdout) proc.stdout.removeAllListeners()
+      if (proc.stderr) proc.stderr.removeAllListeners()
+      resolve(res)
+    }
+
     // Process output is handled by the service management system
     // Individual process logs are no longer logged to console
     if (opts.log !== false) {
-      proc.stdout.on('data', (data) => hooks.emit({ type: 'service:stdout', data, service: label }))
-      proc.stderr.on('data', (data) => hooks.emit({ type: 'service:stderr', data, service: label }))
+      proc.stdout?.on('data', (data) => hooks.emit({ type: 'service:stdout', data, service: label }))
+      proc.stderr?.on('data', (data) => hooks.emit({ type: 'service:stderr', data, service: label }))
       proc.on('error', (error) => hooks.emit({ type: 'service:error', error, service: label }))
     }
 
-    proc.on('exit', res => {
-      delete children[proc.pid]
-      // hooks.emit({ type: 'service:exit', code: res, service: label })
-      resolve(res)
-    })
+    // Handle both exit and close to ensure cleanup
+    proc.once('exit', cleanup)
+    proc.once('close', cleanup)
+    proc.once('error', cleanup)
   })
 }

packages/core/vite/index.ts

@@ -141,8 +141,8 @@ export const resolveViteConfig = async (
 
     const VitePWAPlugin = await import('vite-plugin-pwa').then(m => m.VitePWA)
 
-    // @ts-ignore
-    plugins.push(...VitePWAPlugin({ registerType: 'autoUpdate', ...opts }))
+    const pwaPlugins = VitePWAPlugin({ registerType: 'autoUpdate', ...opts })
+    plugins.push(...(Array.isArray(pwaPlugins) ? pwaPlugins : [pwaPlugins]))
   }
 
   // Get html files from plugins

packages/core/vite/plugins/electron/index.ts

@@ -42,8 +42,7 @@ async function resolveViteConfig(options: ElectronOptions): Promise<InlineConfig
       emptyOutDir: false,
     },
     resolve: {
-      // @ts-ignore
-      browserField: false,
+      browserField: false as const,
       conditions: ['node'],
       mainFields: ['module', 'jsnext:main', 'jsnext'],
     },