Merge pull request #14 from neuralmagic/more-aggressive-cleanup

Perform more aggressive cleanup during weight quantization and add tqdm

Author: mgoin

auto_fp8/quantize.py

@@ -195,7 +195,8 @@ def quantize_weights(
     quantize_config: BaseQuantizeConfig,
     ignored_layers: List[str] = [],
 ):
-    for name, linear in model.named_modules():
+    named_modules = list(model.named_modules())
+    for name, linear in tqdm.tqdm(named_modules, desc="Quantizing weights"):
         if (
             not isinstance(linear, torch.nn.Linear)
             or name in quantize_config.ignored_layers
@@ -205,7 +206,7 @@ def quantize_weights(
         quant_linear = FP8DynamicLinear(quant_weight, quant_scale, linear.bias)
         replace_module(model, name, quant_linear)
         del linear
-    cleanup_memory()
+        cleanup_memory()
 
 
 def quantize_activations(
@@ -214,6 +215,7 @@ def quantize_activations(
     calibration_tokens,
     ignored_layers: List[str] = [],
 ):
+    # Replace weight quantizer with a dynamic activation quantizer observer
     for name, dynamic_quant_linear in model.named_modules():
         if (
             not isinstance(dynamic_quant_linear, FP8DynamicLinear)
@@ -229,14 +231,14 @@ def quantize_activations(
         del dynamic_quant_linear
     cleanup_memory()
 
-    # Calibration.
-    with tqdm.tqdm(total=calibration_tokens.shape[0], desc="Calibrating") as pbar:
+    # Pass through calibration data to measure activation scales
+    with tqdm.tqdm(total=calibration_tokens.shape[0], desc="Calibrating activation scales") as pbar:
         for row_idx in range(calibration_tokens.shape[0]):
             model(calibration_tokens[row_idx].reshape(1, -1))
             cleanup_memory()
             pbar.update(1)
 
-    # Replace dynamic quantizer with StaticLinear for export
+    # Replace dynamic quantizer observer with StaticLinear for export
     for name, quantizer in model.named_modules():
         if (
             not isinstance(quantizer, FP8StaticLinearQuantizer)