Skip to content

Commit b640db1

Browse files
authored
don't run multigpu tests twice, run SP in separate test (axolotl-ai-cloud#2542)
* don't run multigpu tests twice, run SP in separate test * fix multiline
1 parent 4ce469d commit b640db1

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

cicd/multigpu.sh

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
#!/bin/bash
22
set -e
33

4-
# only run one test at a time so as not to OOM the GPU
5-
pytest -v --durations=10 -n2 /workspace/axolotl/tests/e2e/multigpu/ --ignore=/workspace/axolotl/tests/e2e/multigpu/solo/
6-
pytest -v --durations=10 -n1 /workspace/axolotl/tests/e2e/multigpu/solo/
7-
84
# Only run two tests at a time to avoid OOM on GPU (with coverage collection)
95
pytest -v -n2 \
10-
--ignore=/workspace/axolotl/tests/e2e/multigpu/solo/
6+
--ignore=/workspace/axolotl/tests/e2e/multigpu/solo/ \
7+
--ignore=/workspace/axolotl/tests/e2e/multigpu/patched/ \
118
/workspace/axolotl/tests/e2e/multigpu/ \
129
--cov=axolotl \
1310
--cov-report=xml:multigpu-coverage.xml
@@ -17,6 +14,11 @@ pytest -v --durations=10 -n1 /workspace/axolotl/tests/e2e/multigpu/solo/ \
1714
--cov-append \
1815
--cov-report=xml:multigpu-coverage.xml
1916

17+
pytest -v --durations=10 -n1 /workspace/axolotl/tests/e2e/multigpu/patched/ \
18+
--cov=axolotl \
19+
--cov-append \
20+
--cov-report=xml:multigpu-coverage.xml
21+
2022
# Upload coverage to Codecov
2123
if [ -f multigpu-coverage.xml ]; then
2224
codecov -f multigpu-coverage.xml -F multigpu,docker-tests,pytorch-${PYTORCH_VERSION}

tests/e2e/multigpu/patched/__init__.py

Whitespace-only changes.

tests/e2e/multigpu/test_sp.py renamed to tests/e2e/multigpu/patched/test_sp.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
from axolotl.utils.dict import DictDefault
1212

13-
from ..utils import check_tensorboard
13+
from ...utils import check_tensorboard
1414

1515
os.environ["WANDB_DISABLED"] = "true"
1616

0 commit comments

Comments
 (0)