Skip to content

Commit c405348

Browse files
djsaundeDan Saunders
andauthored
Codecov fixes / improvements (axolotl-ai-cloud#2549)
* adding codecov reporting * random change * codecov fixes * adding missing dependency * fix --------- Co-authored-by: Dan Saunders <[email protected]>
1 parent a6d28d1 commit c405348

File tree

8 files changed

+18
-20
lines changed

8 files changed

+18
-20
lines changed

.github/workflows/multi-gpu-e2e.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ jobs:
6767
echo "CUDA=${{ matrix.cuda }}" >> $GITHUB_ENV
6868
echo "N_GPUS=${{ matrix.num_gpus }}" >> $GITHUB_ENV
6969
echo "NIGHTLY_BUILD=${{ matrix.nightly_build }}" >> $GITHUB_ENV
70+
echo "CODECOV_TOKEN=${{ secrets.CODECOV_TOKEN }}" >> $GITHUB_ENV
7071
- name: Run tests job on Modal
7172
run: |
7273
modal run cicd.multigpu

.github/workflows/tests-nightly.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ jobs:
147147
echo "CUDA=${{ matrix.cuda }}" >> $GITHUB_ENV
148148
echo "N_GPUS=${{ matrix.num_gpus }}" >> $GITHUB_ENV
149149
echo "NIGHTLY_BUILD=${{ matrix.nightly_build }}" >> $GITHUB_ENV
150+
echo "CODECOV_TOKEN=${{ secrets.CODECOV_TOKEN }}" >> $GITHUB_ENV
150151
- name: Run tests job on Modal
151152
run: |
152153
modal run cicd.e2e_tests

.github/workflows/tests.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ jobs:
109109
- name: Upload coverage to Codecov
110110
uses: codecov/codecov-action@v5
111111
with:
112+
token: ${{ secrets.CODECOV_TOKEN }}
112113
files: ./coverage.xml
113114
flags: unittests,pytorch-${{ matrix.pytorch_version }}
114115
fail_ci_if_error: false
@@ -241,6 +242,7 @@ jobs:
241242
echo "CUDA=${{ matrix.cuda }}" >> $GITHUB_ENV
242243
echo "MODAL_IMAGE_BUILDER_VERSION=2024.10" >> $GITHUB_ENV
243244
echo "N_GPUS=${{ matrix.num_gpus }}" >> $GITHUB_ENV
245+
echo "CODECOV_TOKEN=${{ secrets.CODECOV_TOKEN }}" >> $GITHUB_ENV
244246
- name: Run tests job on Modal
245247
run: |
246248
modal run cicd.e2e_tests
@@ -288,6 +290,7 @@ jobs:
288290
echo "CUDA=${{ matrix.cuda }}" >> $GITHUB_ENV
289291
echo "MODAL_IMAGE_BUILDER_VERSION=2024.10" >> $GITHUB_ENV
290292
echo "N_GPUS=${{ matrix.num_gpus }}" >> $GITHUB_ENV
293+
echo "CODECOV_TOKEN=${{ secrets.CODECOV_TOKEN }}" >> $GITHUB_ENV
291294
- name: Run tests job on Modal
292295
run: |
293296
modal run cicd.e2e_tests

cicd/cicd.sh

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ pytest -v --durations=10 -n8 \
99
--ignore=tests/patched/ \
1010
--ignore=tests/cli \
1111
/workspace/axolotl/tests/ \
12-
--cov=axolotl \
13-
--cov-report=xml:coverage.xml
12+
--cov=axolotl
1413

1514
# Run lora kernels tests with coverage append
1615
pytest -v --durations=10 \
@@ -51,11 +50,6 @@ pytest -v --durations=10 \
5150
/workspace/axolotl/tests/e2e/ \
5251
--cov=axolotl \
5352
--cov-append \
54-
--cov-report=xml:coverage.xml
55-
56-
# Upload coverage to Codecov
57-
if [ -f e2e-coverage.xml ]; then
58-
codecov -f e2e-coverage.xml -F e2e,pytorch-${PYTORCH_VERSION}
59-
else
60-
echo "Coverage file not found. Coverage report may have failed."
61-
fi
53+
--cov-report=xml:e2e-coverage.xml
54+
55+
codecov upload-process -t $CODECOV_TOKEN -f e2e-coverage.xml -F e2e,pytorch-${PYTORCH_VERSION}

cicd/e2e_tests.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"GITHUB_REF": os.environ.get("GITHUB_REF", "refs/heads/main"),
2929
"GITHUB_SHA": os.environ.get("GITHUB_SHA", ""),
3030
"NIGHTLY_BUILD": os.environ.get("NIGHTLY_BUILD", ""),
31+
"CODECOV_TOKEN": os.environ.get("CODECOV_TOKEN", ""),
3132
"HF_HOME": "/workspace/data/huggingface-cache/hub",
3233
}
3334

cicd/multigpu.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"CUDA": os.environ.get("CUDA", "121"),
3030
"GITHUB_REF": os.environ.get("GITHUB_REF", "refs/heads/main"),
3131
"GITHUB_SHA": os.environ.get("GITHUB_SHA", ""),
32+
"CODECOV_TOKEN": os.environ.get("CODECOV_TOKEN", ""),
3233
"HF_HOME": "/workspace/data/huggingface-cache/hub",
3334
}
3435

cicd/multigpu.sh

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,18 @@ pytest -v -n2 \
66
--ignore=/workspace/axolotl/tests/e2e/multigpu/solo/ \
77
--ignore=/workspace/axolotl/tests/e2e/multigpu/patched/ \
88
/workspace/axolotl/tests/e2e/multigpu/ \
9-
--cov=axolotl \
10-
--cov-report=xml:multigpu-coverage.xml
9+
--cov=axolotl
1110

12-
pytest -v --durations=10 -n1 /workspace/axolotl/tests/e2e/multigpu/solo/ \
11+
# Run solo tests with coverage append
12+
pytest -v --durations=10 -n1 \
13+
/workspace/axolotl/tests/e2e/multigpu/solo/ \
1314
--cov=axolotl \
14-
--cov-append \
15-
--cov-report=xml:multigpu-coverage.xml
15+
--cov-append
1616

1717
pytest -v --durations=10 -n1 /workspace/axolotl/tests/e2e/multigpu/patched/ \
1818
--cov=axolotl \
1919
--cov-append \
2020
--cov-report=xml:multigpu-coverage.xml
2121

2222
# Upload coverage to Codecov
23-
if [ -f multigpu-coverage.xml ]; then
24-
codecov -f multigpu-coverage.xml -F multigpu,docker-tests,pytorch-${PYTORCH_VERSION}
25-
else
26-
echo "Coverage file not found. Coverage report may have failed."
27-
fi
23+
codecov upload-process -t $CODECOV_TOKEN -f multigpu-coverage.xml -F multigpu,docker-tests,pytorch-${PYTORCH_VERSION}

requirements-tests.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
codecov
2+
codecov-cli
23
pytest
34
pytest-cov
45
pytest-retry

0 commit comments

Comments
 (0)