Skip to content

Add block strategy and structure validation #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

Add block strategy and structure validation #483

merged 2 commits into from
Oct 8, 2025
+23 −8

Conversation

kylesayrs
Copy link
Contributor

Purpose

  • Give user errors which require that block strategy and structure are both specified

@kylesayrs
add validation
15450a1 
Signed-off-by: Kyle Sayers <[email protected]>
dsikka
dsikka previously approved these changes Oct 7, 2025
View reviewed changes
@kylesayrs
fix test
2241c5b 
Signed-off-by: Kyle Sayers <[email protected]>
shanjiaz
shanjiaz approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@shanjiaz shanjiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kylesayrs kylesayrs merged commit 5121d47 into main Oct 8, 2025
2 checks passed
@kylesayrs kylesayrs deleted the kylesayrs/block-validation branch October 8, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@shanjiaz shanjiaz shanjiaz approved these changes

@dsikka dsikka dsikka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kylesayrs @brian-dellabetta @dsikka @shanjiaz