Skip to content

Commit 0a2f4c0

Browse files
authored
[Models] Use in-place adds in Idefics2Vision (vllm-project#23932)
Signed-off-by: Lukas Geiger <[email protected]>
1 parent 1cf3753 commit 0a2f4c0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

vllm/model_executor/models/idefics2_vision_model.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def forward(self,
108108
bucket_coords_w).flatten()
109109
position_ids[batch_idx][p_attn_mask.view(-1).cpu()] = pos_ids
110110
position_ids = position_ids.to(self.position_embedding.weight.device)
111-
embeddings = embeddings + self.position_embedding(position_ids)
111+
embeddings += self.position_embedding(position_ids)
112112
return embeddings
113113

114114

@@ -262,11 +262,11 @@ def forward(
262262
residual = hidden_states
263263
hidden_states = self.layer_norm1(hidden_states)
264264
hidden_states = self.self_attn(hidden_states)
265-
hidden_states = residual + hidden_states
265+
hidden_states += residual
266266
residual = hidden_states
267267
hidden_states = self.layer_norm2(hidden_states)
268268
hidden_states = self.mlp(hidden_states)
269-
hidden_states = residual + hidden_states
269+
hidden_states += residual
270270
return hidden_states
271271

272272

0 commit comments

Comments
 (0)