-
Notifications
You must be signed in to change notification settings - Fork 36
Description
Currently ssh (and proposed aws and gdrive tests) cover connection set up and transfer. Other times connection is used (searching next sub / ses) and some edge cases (e.g. different overwrite settings) are not tested. These are instead tested with the local-filesystem method, in particular after #571.
In theory, the current tests should cover all cases. Searching the central filesystem is the core functionality that underlies suggesting the next sub /ses, and it is used for transfer and validation, so is tested there. Similarly rclone settings (overwriting, dry run) are handled by core rclone calls which are the same for all transfer methods, so while these are not explicitly tested for all connection methods if it works for local filesystem, it should work for all.
Nonetheless, while this reflects the current state of the code, it cannot hurt to future-proof by explicitly testing searching for next sub / ses, validation and transfer options for ssh, aws and gdrive tests. This can be done in an extensible way similar to how it has been set up for transfers #570. @cs7-shrey I'll tag you here for your interest, I think this probably is outside the scope of #570 because it also include SSH tests, but could be something to think about once #556 is complete.