Skip to content

Commit 3535f0f

Browse files
committed
Revert "replace valopers"
This reverts commit 4074f2f.
1 parent df0de1d commit 3535f0f

File tree

2 files changed

+11
-29
lines changed

2 files changed

+11
-29
lines changed

app/upgrades/v6.0.0/deics.go

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ const (
3737
//go:embed validators/staking
3838
var Vals embed.FS
3939

40-
var ValoperReplacements = map[string]string{
41-
"neutronvaloper15x2ml0qepktnd6egk4l0rtl0z8fpfxktmzww59": "neutronvaloper1sgr7u20etqn453k3qcfqldrj5fnahl4q8vngzu",
42-
}
43-
4440
type StakingValidator struct {
4541
Valoper string `json:"valoper"`
4642
Moniker string `json:"moniker,omitempty"`
@@ -120,29 +116,20 @@ func MoveICSToStaking(ctx sdk.Context, sk stakingkeeper.Keeper, bk bankkeeper.Ke
120116

121117
// Add all ICS validators to staking module
122118
for i, v := range consumerValidators {
123-
va := v.GetAddress()
124-
valoperAddr, err := bech32.ConvertAndEncode("neutronvaloper", va)
125-
if err != nil {
126-
return err
127-
}
128-
129-
if replacement, ok := ValoperReplacements[valoperAddr]; ok {
130-
valoperAddr = replacement
131-
_, va, err = bech32.DecodeAndConvert(valoperAddr)
132-
if err != nil {
133-
return err
134-
}
135-
}
136-
137119
// funding ICS valopers from DAO to stake a coin
138-
err = bk.SendCoins(ctx, DAOaddr, va, sdk.NewCoins(sdk.Coin{
120+
err := bk.SendCoins(ctx, DAOaddr, v.GetAddress(), sdk.NewCoins(sdk.Coin{
139121
Denom: params.DefaultDenom,
140122
Amount: math.NewInt(ICSSelfStake),
141123
}))
142124
if err != nil {
143125
return err
144126
}
145127

128+
valoperAddr, err := bech32.ConvertAndEncode("neutronvaloper", v.GetAddress())
129+
if err != nil {
130+
return err
131+
}
132+
146133
consPubKey, err := v.ConsPubKey()
147134
if err != nil {
148135
return err
@@ -184,12 +171,12 @@ func MoveICSToStaking(ctx sdk.Context, sk stakingkeeper.Keeper, bk bankkeeper.Ke
184171
return err
185172
}
186173

187-
err = sk.SetLastValidatorPower(ctx, va, 1)
174+
err = sk.SetLastValidatorPower(ctx, v.GetAddress(), 1)
188175
if err != nil {
189176
return err
190177
}
191178

192-
savedVal, err := sk.GetValidator(ctx, va)
179+
savedVal, err := sk.GetValidator(ctx, v.GetAddress())
193180
if err != nil {
194181
return err
195182
}

app/upgrades/v6.0.0/upgrades_test.go

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,6 @@ func (suite *UpgradeTestSuite) TestUpgrade() {
145145
commonAddress = expVals[mapKeys(expVals)[0]]
146146
pk = &commonAddress
147147
}
148-
if i == 1 {
149-
addr = "neutronvaloper15x2ml0qepktnd6egk4l0rtl0z8fpfxktmzww59" // first valoper map key
150-
_, ccvAddr, err = bech32.DecodeAndConvert(addr)
151-
require.NoError(t, err)
152-
}
153148
ccvVals[addr] = pk
154149
anyPK, err := types2.NewAnyWithValue(pk)
155150
require.NoError(t, err)
@@ -213,7 +208,8 @@ func (suite *UpgradeTestSuite) TestUpgrade() {
213208
countStaking++
214209
require.Equal(t, newVal.Status, types.Unbonded)
215210
require.Equal(t, newVal.Tokens, math.NewInt(v600.SovereignSelfStake))
216-
} else if _, ok := ccvVals[newVal.OperatorAddress]; ok {
211+
}
212+
if _, ok := ccvVals[newVal.OperatorAddress]; ok {
217213
countCCV++
218214
require.Equal(t, newVal.Status, types.Bonded)
219215
require.Equal(t, newVal.Tokens, math.NewInt(v600.ICSSelfStake))
@@ -223,8 +219,7 @@ func (suite *UpgradeTestSuite) TestUpgrade() {
223219
require.Equal(t, countStaking, len(expectedVals))
224220

225221
// all ccv vals in the set, except the one we created as common
226-
// -1 because of shared valoper
227-
require.Equal(t, countCCV, len(ccvVals)-commonValidators-1)
222+
require.Equal(t, countCCV, len(ccvVals)-commonValidators)
228223

229224
bondedBalanceAfter, err := app.BankKeeper.Balance(ctx, &banktypes.QueryBalanceRequest{
230225
Address: authtypes.NewModuleAddress(types.BondedPoolName).String(),

0 commit comments

Comments
 (0)