Skip to content

Commit 0f6511e

Browse files
author
Glass
authored
Modify default values for global and per run rebin settings (#187)
* Modify default values for global and per run rebin settings * fix test
1 parent 76a4332 commit 0f6511e

File tree

8 files changed

+321
-360
lines changed

8 files changed

+321
-360
lines changed

.github/pull_request_template.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
## Description of work:
22

33
Check all that apply:
4-
- [ ] added [release notes](https://reflectivity-ui.readthedocs.io/en/latest/release_notes.html)
54
(if not, provide an explanation in the work description)
65
- [ ] updated documentation and checked that it looks correct in the [pull request preview](https://docs.readthedocs.com/platform/stable/pull-requests.html)
76
- [ ] Source added/refactored
@@ -17,8 +16,6 @@ Check all that apply:
1716
([instructions to set up the environment](https://reflectivity-ui.readthedocs.io/en/latest/developer/environment.html))
1817

1918
# Check list for the reviewer
20-
- [ ] [release notes](https://reflectivity-ui.readthedocs.io/en/latest/releasenotes/index.html) updated,
21-
or an explanation is provided as to why release notes are unnecessary
2219
- [ ] best software practices
2320
+ [ ] clearly named variables (better to be verbose in variable names)
2421
+ [ ] code comments explaining the intent of code blocks

docs/developer/release.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ How to Make a Release
88

99
Candidate and Production Releases
1010
---------------------------------
11-
- Follow the `Software Maturity Model <https://ornl-neutrons.atlassian.net/wiki/spaces/NDPD/pages/23363585/Software+Maturity+Model>`_
11+
- Follow the `Software Release Process <https://ornl-neutrons.atlassian.net/wiki/x/AYBkAQ>`_
1212
for continuous versioning, as well as creating Candidate and Production releases.\
13-
- Right before a Major or Minor release, update the release notes file ``docs/release_notes.rst``.
1413
- Then create a new Release Candidate (rc) just to include these changes in the release.
1514

1615

docs/release_notes.rst

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3,33 +3,9 @@
33
44
Release Notes
55
=============
6-
Notes for major and minor releases. Notes for Patch releases are deferred.
76

8-
..
9-
Use the following template to add a new release note.
10-
11-
<Next Release>
12-
--------------
13-
(date of release, format YYYY-MM-DD)
14-
15-
**Of interest to the User:**
16-
- PR #XYZ: one-liner description
17-
18-
**Of interest to the Developer:**
19-
- PR #XYZ: one-liner description
20-
..
21-
22-
..
23-
4.8.0
24-
-----
25-
(date of release, format YYYY-MM-DD)
26-
27-
**Of interest to the User:**
28-
- PR #XYZ: one-liner description
29-
30-
**Of interest to the Developer:**
31-
- PR #180: MrRed version number updated and related dependencies were added
32-
..
7+
For release notes after `v4.7.0`,
8+
see the `GitHub release notes <https://github.com/neutrons/quicknxs/releases>`_.
339

3410
4.7.0
3511
-----

src/quicknxs/interfaces/configuration.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ class Configuration(object):
3636
use_constant_q = False
3737
wl_bandwidth = 3.2
3838
# Final Q rebin global options
39-
do_final_rebin_global = True
40-
final_rebin_step_global = -0.01
39+
do_final_rebin_global = False
40+
final_rebin_step_global = -0.02
4141
# Normalize to unity when stitching
4242
normalize_to_unity = True
4343
total_reflectivity_q_cutoff = 0.01
@@ -75,8 +75,8 @@ def setup_default_values(cls):
7575
cls.sample_size = 10
7676
cls.use_constant_q = False
7777
cls.wl_bandwidth = 3.2
78-
cls.do_final_rebin_global = True
79-
cls.final_rebin_step_global = -0.01
78+
cls.do_final_rebin_global = False
79+
cls.final_rebin_step_global = -0.02
8080
cls.normalize_to_unity = True
8181
cls.total_reflectivity_q_cutoff = 0.01
8282
cls.global_stitching = False
@@ -147,7 +147,7 @@ def __init__(self):
147147

148148
# Final Rebin run options
149149
self.do_final_rebin_run = False
150-
self.final_rebin_step_run = -0.01
150+
self.final_rebin_step_run = -0.02
151151

152152
# UI elements
153153
self.normalize_x_tof = False

0 commit comments

Comments
 (0)