fix: NVSHAS-8383 ClusterIP as the default

NodePort is for evaluation only and not secure.  It should not be used
as the default option.

Author: holyspectral

charts/core/values.yaml

@@ -366,7 +366,7 @@ manager:
   #      - name: CUSTOM_PAGE_FOOTER_COLOR
   #        value: "#FFFFFF"
   svc:
-    type: NodePort # should be set to - ClusterIP
+    type: ClusterIP
     nodePort:  
     loadBalancerIP:
     annotations:
@@ -484,7 +484,7 @@ cve:
       protocol: https
       secretName:
     svc:
-      type: NodePort # should be set to - ClusterIP
+      type: ClusterIP
       loadBalancerIP:
       annotations:
         {}

test/service_test.go

@@ -272,7 +272,7 @@ func TestManagerService(t *testing.T) {
 	var svc corev1.Service
 	helm.UnmarshalK8SYaml(t, outs[0], &svc)
 
-	checkManagerService(t, svc, "NodePort")
+	checkManagerService(t, svc, "ClusterIP")
 }
 
 func TestManagerServiceLB(t *testing.T) {
@@ -384,4 +384,4 @@ func TestFedManagedServiceLBIP(t *testing.T) {
 	}
 
 	checkControllerServiceFedManaged(t, svc, svcType)
-}
+}