fix: NVSHAS-9662 fix inconsistent role bindings

Remove a few role bindings when internal.autoGenerateCert is disabled

Author: holyspectral

charts/core/templates/rolebinding-least.yaml

@@ -98,7 +98,6 @@ subjects:
 userNames:
 - system:serviceaccount:{{ .Release.Namespace }}:controller
 {{- end }}
-{{- end }}
 ---
 {{- if $oc3 }}
 apiVersion: authorization.openshift.io/v1
@@ -128,6 +127,7 @@ subjects:
 userNames:
 - system:serviceaccount:{{ .Release.Namespace }}:cert-upgrader
 {{- end }}
+{{- end }}
 ---
 {{- if $oc3 }}
 apiVersion: authorization.openshift.io/v1

charts/core/templates/rolebinding.yaml

@@ -110,7 +110,6 @@ subjects:
 - kind: ServiceAccount
   name: {{ .Values.serviceAccount }}
   namespace: {{ .Release.Namespace }}
-{{- end }}
 ---
 {{- if $oc3 }}
 apiVersion: authorization.openshift.io/v1
@@ -170,4 +169,5 @@ userNames:
 - system:serviceaccount:{{ .Release.Namespace }}:cert-upgrader
 {{- end }}
 {{- end }}
+{{- end }}