Skip to content

Commit 4e70b17

Browse files
committed
Fix: UI styling issues on the Vulnerability detail page
1 parent 0b6774b commit 4e70b17

File tree

2 files changed

+28
-12
lines changed

2 files changed

+28
-12
lines changed

pkg/sbombastic-image-vulnerability-scanner/components/CveDetails.vue

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,10 @@ export default {
112112
<div class="about">
113113
<div class="header-section">
114114
<div class="title">
115-
<RouterLink :to="`/c/${this.$route.params.cluster}/${this.PRODUCT_NAME}/${this.PAGE.VULNERABILITIES}`">{{ t('imageScanner.vulnerabilities.title') }}:</RouterLink>
116-
{{ $route.params.id }}
115+
<span class="resource-header-name">
116+
<RouterLink :to="`/c/${this.$route.params.cluster}/${this.PRODUCT_NAME}/${this.PAGE.VULNERABILITIES}`">{{ t('imageScanner.vulnerabilities.title') }}:</RouterLink>
117+
{{ $route.params.id }}
118+
</span>
117119
<BadgeState
118120
:color="getSeverityColor(cveDetail.severity)"
119121
:label="t(`imageScanner.enum.cve.${cveDetail.severity}`)"
@@ -165,9 +167,12 @@ export default {
165167
<div class="stat-item">
166168
<span class="label">Sources</span>
167169
<span class="value">
168-
<a v-for="(source, index) in cveDetail.sources" :key="index" :href="source.link" target="_blank" class="source-link">
169-
{{ source.name }}
170-
</a>
170+
<span v-for="(source, index) in cveDetail.sources" :key="index">
171+
<a :href="source.link" target="_blank" class="source-link">
172+
{{ source.name }} <i class="ml-8 icon icon-external-link" />
173+
</a>
174+
<span v-if="index < cveDetail.sources.length - 1">, </span>
175+
</span>
171176
</span>
172177
</div>
173178
</div>
@@ -213,7 +218,7 @@ export default {
213218
</div>
214219
<div class="cvss-list">
215220
<a v-for="(score, index) in cveDetail.cvssScores" :key="index" :href="score.link" target="_blank" class="cvss-link">
216-
{{ score.source }} {{ score.score }}
221+
{{ score.source }} {{ score.score }} <i class="ml-8 icon icon-external-link" />
217222
</a>
218223
</div>
219224
</div>
@@ -284,7 +289,7 @@ export default {
284289
.about {
285290
/* layout */
286291
display: flex;
287-
padding-bottom: 24px;
292+
padding-bottom: 20px;
288293
flex-direction: column;
289294
align-items: flex-start;
290295
align-self: stretch;
@@ -304,14 +309,14 @@ export default {
304309
305310
.header-section {
306311
display: flex;
307-
align-items: flex-start;
312+
align-items: center;
308313
gap: 24px;
309314
align-self: stretch;
310315
311316
.title {
312317
display: flex;
313318
align-items: flex-start;
314-
gap: 4px;
319+
gap: 12px;
315320
flex: 1 0 0;
316321
color: #141419;
317322
font-family: Lato;
@@ -360,6 +365,7 @@ export default {
360365
font-style: normal;
361366
font-weight: 400;
362367
line-height: 21px;
368+
margin-bottom: 4px;
363369
}
364370
.label {
365371
display: flex;
@@ -431,8 +437,8 @@ export default {
431437
}
432438
433439
.ref-url {
434-
display: block;
435-
color: #0073e6;
440+
display: inline-flex;
441+
color: #5696ce;
436442
text-decoration: none;
437443
word-break: break-all;
438444
}
@@ -447,12 +453,13 @@ export default {
447453
flex-direction: column;
448454
}
449455
.cvss-link, .source-link {
450-
color: #007bff;
456+
color: #5696ce;
451457
text-decoration: none;
452458
margin-bottom: 5px;
453459
}
454460
.cvss-link:hover, .source-link:hover {
455461
text-decoration: underline;
462+
456463
}
457464
.popup {
458465
position: fixed;
@@ -486,4 +493,12 @@ export default {
486493
width: 100%;
487494
}
488495
496+
.table-top-right {
497+
display: flex;
498+
align-items: center;
499+
gap: 16px;
500+
}
501+
.ml-8 {
502+
margin-left: 8px;
503+
}
489504
</style>

pkg/sbombastic-image-vulnerability-scanner/edit/sbombastic.rancher.io.registry.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ export default {
203203
<LabeledSelect
204204
v-model:value="value.spec.authSecret"
205205
data-testid="auth-secret-select"
206+
:label="t('imageScanner.registries.configuration.cru.authentication.label')"
206207
:mode="mode"
207208
:options="options"
208209
/>

0 commit comments

Comments
 (0)