Corrected unit test cases, clear up unnecessary code

Author: xingzhang-suse

pkg/sbombastic-image-vulnerability-scanner/components/__tests__/ImageDetails.spec.ts

@@ -348,7 +348,8 @@ describe('ImageDetails', () => {
 
     it('should have correct filter defaults', () => {
       expect(wrapper.vm.filters.cveSearch).toBe('');
-      expect(wrapper.vm.filters.score).toBe('');
+      expect(wrapper.vm.filters.scoreMin).toBe('');
+      expect(wrapper.vm.filters.scoreMax).toBe('');
       expect(wrapper.vm.filters.packageSearch).toBe('');
       expect(wrapper.vm.filters.fixAvailable).toBe('any');
       expect(wrapper.vm.filters.severity).toBe('any');

pkg/sbombastic-image-vulnerability-scanner/pages/c/_cluster/sbombastic-image-vulnerability-scanner/RegistriesConfiguration.vue

@@ -103,7 +103,6 @@
     <SortableTable
       ref="registryTable"
       :headers="headers"
-      :paginationHeaders="paginationHeaders"
       :schema="schema"
       :namespaced="false"
       :table-actions="true"
@@ -143,9 +142,7 @@
   import {
     PRODUCT_NAME,
   } from "@pkg/types";
-  import { escapeHtml } from '@shell/utils/string';
   import day from 'dayjs';
-  import { DATE_FORMAT, TIME_FORMAT } from '@shell/store/prefs';
   import { findBy } from '@shell/utils/array';
   import ScanButton from "@pkg/components/common/ScanButton";
   import { FilterArgs, PaginationFilterField, PaginationParamFilter } from '@shell/types/store/pagination.types';
@@ -178,7 +175,6 @@
         latestUpdateTime: null,
         statusSummary: {},
         headers: REGISTRY_SCAN_TABLE,
-        paginationHeaders: [],
         selectedRows: [],
         filters: {
           registrySearch: '',
@@ -324,17 +320,6 @@
         const args = { id: RESOURCE.REGISTRY };
         return this.$store.getters[`cluster/paginationEnabled`]?.(args);
       },
-      paginationHeaders() {
-        const headers = REGISTRY_SCAN_TABLE.map(header => {
-          // if (this.canPaginate) {
-          //   console.log("canPaginate", this.canPaginate);
-          //   header.sort = false;
-          //   header.search = false;
-          // }
-          return header;
-        });
-        return headers;
-      },
       latestUpdateDateText() {
         return day(new Date(this.latestUpdateTime).getTime()).format('MMM D, YYYY');
       },

pkg/sbombastic-image-vulnerability-scanner/pages/c/_cluster/sbombastic-image-vulnerability-scanner/__tests__/RegistriesConfiguration.spec.ts

@@ -55,7 +55,7 @@ describe('registries.vue', () => {
     const refreshSpy = jest.spyOn(wrapper.vm, 'loadData').mockResolvedValue();
 
     await wrapper.find('button[aria-label="Refresh data"]').trigger('click');
-    expect(refreshSpy).toHaveBeenCalledWith(true);
+    expect(refreshSpy).toHaveBeenCalled();
   });
 
   it('navigates to create registry when Create is clicked', async () => {
@@ -88,20 +88,4 @@ describe('registries.vue', () => {
     expect(rows[0].metadata.name).toBe('reg1');
   });
 
-  it('filterByStatus updates input value and triggers events', async () => {
-    document.body.innerHTML = `
-      <input type="search" placeholder="Filter" aria-label="Filter table results" />
-    `;
-
-    const wrapper = factory();
-    const el = document.querySelector('input[type="search"]');
-
-    const inputSpy = jest.fn();
-    el?.addEventListener('input', inputSpy);
-
-    wrapper.vm.filterByStatus('active');
-
-    expect((el as HTMLInputElement)?.value).toBe('active');
-    expect(inputSpy).toHaveBeenCalled();
-  });
 });