Skip to content

Commit fc0de55

Browse files
xingzhang-suseNickChungSUSE
authored andcommitted
Integrated installation route with dashbaord. Fixed bugs on some components
1 parent 7db41ee commit fc0de55

File tree

7 files changed

+16
-59
lines changed

7 files changed

+16
-59
lines changed

pkg/sbombastic-image-vulnerability-scanner/components/TopRiskyImagesChart.vue

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,19 @@
44
Most affected images at risk
55
</div>
66
<div class="image-record" v-for="image in topRiskyImages">
7-
<div class="image-name">{{ image.imageName }}</div>
7+
<RouterLink class="image-name" :to="`/c/${this.$route.params.cluster}/${ this.PRODUCT_NAME }/${ this.PAGE.IMAGE_DETAIL }/${ image.imageName }`">
8+
{{ image.imageName }}
9+
</RouterLink>
810
<AmountBarBySeverity class="image-cve" :cveAmount="image.cveCnt"/>
911
</div>
1012
</div>
1113
</template>
1214

1315
<script>
14-
import AmountBarBySeverity from "@pkg/components/common/AmountBarBySeverity";
16+
import AmountBarBySeverity from "@pkg/components/common/AmountBarBySeverity";import {
17+
PRODUCT_NAME,
18+
PAGE,
19+
} from "@pkg/types";
1520
export default {
1621
name: 'amountBarBySeverity',
1722
components: {
@@ -23,6 +28,12 @@
2328
default: () => []
2429
}
2530
},
31+
data() {
32+
return {
33+
PRODUCT_NAME,
34+
PAGE,
35+
};
36+
},
2637
}
2738
</script>
2839

pkg/sbombastic-image-vulnerability-scanner/components/TopSevereVulnerabilitiesChart.vue

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<SevereVulnerabilitiesItem
88
v-for="vulnerability in topSevereVulnerabilities"
99
:vulnerability="vulnerability"
10-
:eventHandler="eventHandler"
1110
/>
1211
</div>
1312
</div>
@@ -26,10 +25,6 @@
2625
type: Array,
2726
required: true
2827
},
29-
eventHandler: {
30-
type: Function,
31-
default: null
32-
}
3328
},
3429
data() {}
3530
}

pkg/sbombastic-image-vulnerability-scanner/components/common/SevereVulnerabilitiesItem.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
<script>
2121
import BlockPercentageBar from './BlockPercentageBar.vue';
2222
import ScoreBadge from './ScoreBadge.vue';
23+
import debounce from 'lodash/debounce';
2324
2425
export default {
2526
name: 'severeVulnerabilitiesItem',
@@ -38,7 +39,7 @@
3839
},
3940
methods: {
4041
resize(fn) {
41-
window.addEventListener('resize', this.debounce(fn), 500);
42+
window.addEventListener('resize', debounce(fn), 500);
4243
},
4344
}
4445
}

pkg/sbombastic-image-vulnerability-scanner/config/sbombastic-image-vulnerability-scanner.ts

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { IPlugin } from "@shell/core/types";
21
import {
32
PRODUCT_NAME,
43
PAGE,
@@ -56,19 +55,6 @@ export function init($plugin: any, store: any) {
5655
}
5756
});
5857

59-
virtualType({
60-
labelKey: "imageScanner.dashboard.title",
61-
name: PAGE.DASHBOARD,
62-
namespaced: false,
63-
route: {
64-
name: `c-cluster-${PRODUCT_NAME}-${PAGE.DASHBOARD}`,
65-
params: {
66-
product: PRODUCT_NAME,
67-
},
68-
meta: { pkg: PRODUCT_NAME, product: PRODUCT_NAME },
69-
},
70-
});
71-
7258
virtualType({
7359
labelKey: "imageScanner.vulnerabilities.title",
7460
name: PAGE.VULNERABILITY_OVERVIEW,
@@ -82,19 +68,6 @@ export function init($plugin: any, store: any) {
8268
},
8369
});
8470

85-
virtualType({
86-
labelKey: "imageScanner.vexManagement.title",
87-
name: PAGE.VEX_MANAGEMENT,
88-
namespaced: false,
89-
route: {
90-
name: `c-cluster-${PRODUCT_NAME}-${PAGE.VEX_MANAGEMENT}`,
91-
params: {
92-
product: PRODUCT_NAME,
93-
},
94-
meta: { pkg: PRODUCT_NAME, product: PRODUCT_NAME },
95-
},
96-
});
97-
9871
virtualType({
9972
label: "Components Demo",
10073
name: "demo",

pkg/sbombastic-image-vulnerability-scanner/pages/c/_cluster/sbombastic-image-vulnerability-scanner/Dashboard.vue

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@
8585
<div class="panel-content">
8686
<TopSevereVulnerabilitiesChart
8787
:topSevereVulnerabilities="displayedVulnerabilities"
88-
:eventHandler="resize"
8988
/>
9089
<div v-if="shouldShowVulnerabilitiesViewAll" class="view-all-inline">
9190
<button class="btn-link view-all-left" @click="toggleVulnerabilitiesView()">
@@ -231,16 +230,6 @@ export default {
231230
}
232231
},
233232
methods: {
234-
resize(fn) {
235-
window.addEventListener('resize', this.debounce(fn), 500);
236-
},
237-
debounce(func, delay = 300) {
238-
let timeout
239-
return function (...args) {
240-
clearTimeout(timeout)
241-
timeout = setTimeout(() => func.apply(this, args), delay)
242-
}
243-
},
244233
toggleVulnerabilitiesView() {
245234
this.showAllVulnerabilities = !this.showAllVulnerabilities;
246235
},

pkg/sbombastic-image-vulnerability-scanner/pages/c/_cluster/sbombastic-image-vulnerability-scanner/ImageOverview.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ import { filter } from "lodash";
168168
169169
methods: {
170170
applyFilters() {
171-
let filtered = this.preprocessedDataset.preprocessedImages;
171+
let filtered = _.cloneDeep(this.preprocessedImagesBak);
172172
if (this.selectedImageFilter.value === "excludeBaseImages" || this.selectedImageFilter === "excludeBaseImages") {
173173
filtered = filtered.filter(image => !image.spec.isBaseImage);
174174
} else if (this.selectedImageFilter.value === "includeBaseImages" || this.selectedImageFilter === "includeBaseImages") {

pkg/sbombastic-image-vulnerability-scanner/routes/sbombastic-image-vulnerability-scanner-routes.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
import RegistryDetails from "@pkg/components/RegistryDetails.vue";
2-
import ComponentDemo from "@pkg/pages/c/_cluster/sbombastic-image-vulnerability-scanner/ComponentDemo.vue";
3-
import Dashboard from "@pkg/pages/c/_cluster/sbombastic-image-vulnerability-scanner/Dashboard.vue";
42
import ImageOverview from "@pkg/pages/c/_cluster/sbombastic-image-vulnerability-scanner/ImageOverview.vue";
53
import ImageDetails from "@pkg/components/ImageDetails.vue";
64
import RegistriesConfiguration from "@pkg/pages/c/_cluster/sbombastic-image-vulnerability-scanner/RegistriesConfiguration.vue";
@@ -19,11 +17,6 @@ const routes = [
1917
path: `/c/:cluster/${ PRODUCT_NAME }/${PAGE.DASHBOARD}`,
2018
component: Entry,
2119
},
22-
{
23-
name: `c-cluster-${PRODUCT_NAME}-${PAGE.DASHBOARD}`,
24-
path: `/c/:cluster/${PRODUCT_NAME}/${PAGE.DASHBOARD}`,
25-
component: Dashboard,
26-
},
2720
{
2821
name: `c-cluster-${PRODUCT_NAME}-${PAGE.IMAGE_OVERVIEW}`,
2922
path: `/c/:cluster/${PRODUCT_NAME}/${PAGE.IMAGE_OVERVIEW}`,
@@ -44,11 +37,6 @@ const routes = [
4437
path: `/c/:cluster/${PRODUCT_NAME}/${PAGE.REGISTRIES}`,
4538
component: RegistriesConfiguration,
4639
},
47-
{
48-
name: `c-cluster-${PRODUCT_NAME}-${PAGE.VEX_MANAGEMENT}`,
49-
path: `/c/:cluster/${PRODUCT_NAME}/${PAGE.VEX_MANAGEMENT}`,
50-
component: VexManagement,
51-
},
5240
{
5341
name: `c-cluster-${PRODUCT_NAME}-${PAGE.REGISTRIES}-id`,
5442
path: `/c/:cluster/${PRODUCT_NAME}/${PAGE.REGISTRIES}/:ns/:id`,

0 commit comments

Comments
 (0)