removed dependency of onboarding-data module and bug fix

Author: abhijitb

bootstrap.php

@@ -7,6 +7,7 @@
 use NewfoldLabs\WP\Module\Onboarding\Compatibility\Safe_Mode;
 use NewfoldLabs\WP\Module\Onboarding\Compatibility\Status;
 use NewfoldLabs\WP\Module\Onboarding\TaskManagers\ImageSideloadTaskManager;
+use NewfoldLabs\WP\Module\Onboarding\Tasks\ImageSideloadTask;
 
 use function NewfoldLabs\WP\ModuleLoader\register;
 

includes/TaskManagers/ImageSideloadTaskManager.php

@@ -3,7 +3,6 @@
 namespace NewfoldLabs\WP\Module\Onboarding\TaskManagers;
 
 use NewfoldLabs\WP\Module\Onboarding\Tasks\ImageSideloadTask;
-use NewfoldLabs\WP\Module\Onboarding\Data\Options;
 
 /**
  * Task Manager for Image Sideloading
@@ -17,14 +16,14 @@ class ImageSideloadTaskManager {
 	 *
 	 * @var string
 	 */
-	const QUEUE_OPTION = 'nfd_image_sideload_queue';
+	const QUEUE_OPTION = 'nfd_module_onboarding_image_sideload_queue';
 
 	/**
 	 * Option name for storing the processing status
 	 *
 	 * @var string
 	 */
-	const STATUS_OPTION = 'nfd_image_sideload_status';
+	const STATUS_OPTION = 'nfd_module_onboarding_image_sideload_status';
 
 	/**
 	 * Add a task to the queue
@@ -62,7 +61,7 @@ public static function add_to_queue( ImageSideloadTask $task ) {
 	 * @return array
 	 */
 	public static function get_queue() {
-		$queue = get_option( Options::get_option_name( self::QUEUE_OPTION ), array() );
+		$queue = get_option( self::QUEUE_OPTION, array() );
 		if ( ! is_array( $queue ) ) {
 			$queue = array();
 		}
@@ -76,7 +75,7 @@ public static function get_queue() {
 	 * @return void
 	 */
 	public static function set_queue( $queue ) {
-		update_option( Options::get_option_name( self::QUEUE_OPTION ), $queue );
+		update_option( self::QUEUE_OPTION, $queue );
 	}
 
 	/**
@@ -85,7 +84,7 @@ public static function set_queue( $queue ) {
 	 * @return string
 	 */
 	public static function get_status() {
-		return get_option( Options::get_option_name( self::STATUS_OPTION ), 'idle' );
+		return get_option( self::STATUS_OPTION, 'idle' );
 	}
 
 	/**
@@ -95,7 +94,7 @@ public static function get_status() {
 	 * @return void
 	 */
 	public static function set_status( $status ) {
-		update_option( Options::get_option_name( self::STATUS_OPTION ), $status );
+		update_option( self::STATUS_OPTION, $status );
 	}
 
 	/**

includes/Tasks/ImageSideloadTask.php

@@ -48,6 +48,10 @@ public function execute() {
 				return $result;
 			}
 
+			if ( false === $result ) {
+				return new \WP_Error( 'upload_failed', 'Image upload returned false' );
+			}
+
 			// Update post content with new image URLs
 			if ( ! empty( $result ) ) {
 				$content_updated = SiteGenImageService::update_post_content_with_new_image_urls( $this->post_id, $result );