lint fixes

Author: abhijitb

bootstrap.php

@@ -83,5 +83,5 @@ function () {
 	);
 
 	// Add action to process image sideload queue
-	add_action( 'nfd_process_image_sideload_queue', [ ImageSideloadTaskManager::class, 'process_queue' ] );
+	add_action( 'nfd_process_image_sideload_queue', array( ImageSideloadTaskManager::class, 'process_queue' ) );
 }

includes/Services/ThemeGeneratorService.php

@@ -7,7 +7,7 @@
 
 /**
  * ThemeGeneratorService for the onboarding module.
- * 
+ *
  * Handles image processing and media library operations for the onboarding flow.
  */
 class ThemeGeneratorService {
@@ -26,11 +26,11 @@ public static function process_homepage_images_immediate_async( $post_id, $conte
 		if ( empty( $image_urls ) ) {
 			return;
 		}
-		
+
 		// Create and add task to queue
 		$task = new ImageSideloadTask( $post_id, $image_urls );
 		ImageSideloadTaskManager::add_to_queue( $task );
-		
+
 		// Schedule a single event to process the queue (if not already scheduled)
 		if ( ! wp_next_scheduled( 'nfd_process_image_sideload_queue' ) ) {
 			wp_schedule_single_event( time(), 'nfd_process_image_sideload_queue' );
@@ -173,4 +173,4 @@ public static function connect_to_filesystem() {
 
 		return true;
 	}
-} 
+}

includes/TaskManagers/ImageSideloadTaskManager.php

@@ -7,7 +7,7 @@
 
 /**
  * Task Manager for Image Sideloading
- * 
+ *
  * Manages a queue of ImageSideloadTask objects and processes them in FIFO order.
  */
 class ImageSideloadTaskManager {
@@ -34,7 +34,7 @@ class ImageSideloadTaskManager {
 	 */
 	public static function add_to_queue( ImageSideloadTask $task ) {
 		$queue = self::get_queue();
-		
+
 		// Check if task already exists
 		$task_id = $task->get_id();
 		foreach ( $queue as $existing_task ) {
@@ -45,11 +45,11 @@ public static function add_to_queue( ImageSideloadTask $task ) {
 
 		// Add task to queue (FIFO - add to end)
 		$queue[] = array(
-			'id'       => $task_id,
-			'post_id'  => $task->get_post_id(),
-			'urls'     => $task->get_image_urls(),
-			'status'   => 'pending',
-			'created'  => time(),
+			'id'      => $task_id,
+			'post_id' => $task->get_post_id(),
+			'urls'    => $task->get_image_urls(),
+			'status'  => 'pending',
+			'created' => time(),
 		);
 
 		self::set_queue( $queue );
@@ -105,45 +105,45 @@ public static function set_status( $status ) {
 	 */
 	public static function process_next_task() {
 		$queue = self::get_queue();
-		
+
 		if ( empty( $queue ) ) {
 			self::set_status( 'idle' );
 			return false;
 		}
 
 		// Get the next task
 		$task_data = array_shift( $queue );
-		
+
 		// Mark as processing
-		$task_data['status'] = 'processing';
+		$task_data['status']  = 'processing';
 		$task_data['started'] = time();
-		
+
 		// Create task object and execute
-		$task = new ImageSideloadTask( $task_data['post_id'], $task_data['urls'] );
+		$task   = new ImageSideloadTask( $task_data['post_id'], $task_data['urls'] );
 		$result = $task->execute();
 
 		if ( is_wp_error( $result ) ) {
 			// Mark as failed
-			$task_data['status'] = 'failed';
-			$task_data['error'] = $result->get_error_message();
+			$task_data['status']    = 'failed';
+			$task_data['error']     = $result->get_error_message();
 			$task_data['completed'] = time();
-			
+
 			// Add back to queue for retry
 			$queue[] = $task_data;
-			
+
 			self::set_queue( $queue );
 			self::set_status( 'processing' );
-			
+
 			return $result;
 		}
 
 		// Mark as completed
-		$task_data['status'] = 'completed';
+		$task_data['status']    = 'completed';
 		$task_data['completed'] = time();
-		
+
 		self::set_queue( $queue );
 		self::set_status( 'processing' );
-		
+
 		return true;
 	}
 
@@ -154,31 +154,31 @@ public static function process_next_task() {
 	 * @return array Array with 'processed' and 'remaining' counts
 	 */
 	public static function process_queue( $max_tasks = 5 ) {
-		$processed = 0;
-		$queue = self::get_queue();
+		$processed     = 0;
+		$queue         = self::get_queue();
 		$initial_count = count( $queue );
 
 		self::set_status( 'processing' );
 
 		while ( $processed < $max_tasks && ! empty( $queue ) ) {
 			$result = self::process_next_task();
-			
-			if ( $result === false ) {
+	
+			if ( false ===$result ) {
 				break; // Queue is empty
 			}
-			
+
 			if ( is_wp_error( $result ) ) {
 				// Continue processing other tasks even if one fails
 				$processed++;
 				continue;
 			}
-			
+
 			$processed++;
 		}
 
 		$remaining = count( self::get_queue() );
-		
-		if ( $remaining === 0 ) {
+
+		if ( 0 === $remaining ) {
 			self::set_status( 'idle' );
 		}
 

includes/Tasks/ImageSideloadTask.php

@@ -43,7 +43,7 @@ public function execute() {
 		try {
 			// Upload images to WordPress media library
 			$result = ThemeGeneratorService::upload_images_to_wp_media_library( $this->image_urls, $this->post_id );
-			
+
 			if ( is_wp_error( $result ) ) {
 				return $result;
 			}
@@ -78,6 +78,6 @@ public function get_image_urls() {
 	 * @return string
 	 */
 	public function get_id() {
-		return 'image_sideload_' . $this->post_id . '_' . md5( serialize( $this->image_urls ) );
+		return 'image_sideload_' . $this->post_id . '_' . md5( maybe_serialize( $this->image_urls ) );
 	}
 }