Skip to content

Commit 4284be6

Browse files
authored
Fix linking MSVC error from forward declaration used as templated type (iree-org#22233)
Fixes a build error for MSVC: https://discord.com/channels/689900678990135345/689957613152239638/1425159686247809054 The MSVC compiler doesn't support using forward declared classes as template types, so this PR just includes the relevant file instead of forward declaring. Confirmed that the MSVC CI action passes: https://github.com/iree-org/iree/actions/runs/18320843225/job/52173225710 Signed-off-by: Max Dawkins <[email protected]>
1 parent f155a52 commit 4284be6

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

compiler/src/iree/compiler/Dialect/Encoding/Utils/Utils.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
#include "iree/compiler/Dialect/Encoding/Utils/Utils.h"
88

9-
#include "iree/compiler/Dialect/LinalgExt/Utils/MatchUtils.h"
109
#include "llvm/ADT/SmallVector.h"
1110
#include "mlir/Dialect/Linalg/Utils/Utils.h"
1211
#include "mlir/IR/AffineMap.h"

compiler/src/iree/compiler/Dialect/Encoding/Utils/Utils.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,11 @@
88
#define IREE_COMPILER_DIALECT_ENCODING_UTILS_UTILS_H_
99

1010
#include "iree/compiler/Dialect/Encoding/IR/EncodingTypes.h"
11+
#include "iree/compiler/Dialect/LinalgExt/Utils/MatchUtils.h"
1112
#include "mlir/IR/Attributes.h"
1213
#include "mlir/IR/BuiltinAttributes.h"
1314
#include "mlir/IR/BuiltinTypes.h"
1415

15-
namespace mlir::iree_compiler::IREE::LinalgExt {
16-
class ScaledContractionDimensions;
17-
} // namespace mlir::iree_compiler::IREE::LinalgExt
18-
1916
namespace mlir::iree_compiler::IREE::Encoding {
2017

2118
constexpr char kDataTilingHint[] = "iree.opt.data_tiling";

0 commit comments

Comments
 (0)