Skip to content

Commit da72851

Browse files
committed
update other usages
1 parent 2508d88 commit da72851

File tree

4 files changed

+20
-15
lines changed

4 files changed

+20
-15
lines changed

lib/new_relic/distributed_trace/w3c_trace_context/trace_state.ex

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,13 @@ defmodule NewRelic.DistributedTrace.W3CTraceContext.TraceState do
9191
length(members) <= 32
9292
end
9393

94-
@key_wo_vendor ~r/^[0-9a-z][_0-9a-z\-\*\/]{0,255}$/
95-
@key_with_vendor ~r/^[0-9a-z][_0-9a-z\-\*\/]{0,240}@[0-9a-z][_0-9a-z\-\*\/]{0,13}$/
96-
@value ~r/^([\x20-\x2b\x2d-\x3c\x3e-\x7e]{0,255}[\x21-\x2b\x2d-\x3c\x3e-\x7e])$/
94+
defp key_wo_vendor, do: ~r/^[0-9a-z][_0-9a-z\-\*\/]{0,255}$/
95+
defp key_with_vendor, do: ~r/^[0-9a-z][_0-9a-z\-\*\/]{0,240}@[0-9a-z][_0-9a-z\-\*\/]{0,13}$/
96+
defp valid_value, do: ~r/^([\x20-\x2b\x2d-\x3c\x3e-\x7e]{0,255}[\x21-\x2b\x2d-\x3c\x3e-\x7e])$/
97+
9798
defp valid_member?([key, value]) do
98-
valid_key? = Regex.match?(@key_wo_vendor, key) || Regex.match?(@key_with_vendor, key)
99-
valid_value? = Regex.match?(@value, value)
99+
valid_key? = Regex.match?(key_wo_vendor(), key) || Regex.match?(key_with_vendor(), key)
100+
valid_value? = Regex.match?(valid_value(), value)
100101

101102
valid_key? && valid_value?
102103
end

lib/new_relic/harvest/telemetry_sdk/config.ex

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,13 @@ defmodule NewRelic.Harvest.TelemetrySdk.Config do
1010
Application.get_env(:new_relic_agent, key, @default[key])
1111
end
1212

13-
@region_matcher ~r/^(?<region>\D+)/
14-
@env_matcher ~r/^(?<env>.+)-collector/
13+
defp region_matcher, do: ~r/^(?<region>\D+)/
14+
defp env_matcher, do: ~r/^(?<env>.+)-collector/
15+
1516
def determine_hosts(host, region) do
16-
env = host && Regex.named_captures(@env_matcher, host)["env"]
17+
env = host && Regex.named_captures(env_matcher(), host)["env"]
1718
env = env && env <> "-"
18-
region = region && Regex.named_captures(@region_matcher, region)["region"] <> "."
19+
region = region && Regex.named_captures(region_matcher(), region)["region"] <> "."
1920

2021
%{
2122
log: "https://#{env}log-api.#{region}newrelic.com/log/v1",

lib/new_relic/init.ex

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,12 @@ defmodule NewRelic.Init do
4646
})
4747
end
4848

49-
@region_matcher ~r/^(?<prefix>.+?)x/
49+
defp region_matcher, do: ~r/^(?<prefix>.+?)x/
50+
5051
def determine_region(nil), do: nil
5152

5253
def determine_region(license_key) do
53-
case Regex.named_captures(@region_matcher, license_key) do
54+
case Regex.named_captures(region_matcher(), license_key) do
5455
%{"prefix" => prefix} -> String.trim_trailing(prefix, "x")
5556
_ -> nil
5657
end
@@ -191,11 +192,12 @@ defmodule NewRelic.Init do
191192

192193
def parse_labels(nil), do: []
193194

194-
@label_splitter ~r/;|:/
195195
def parse_labels(label_string) do
196196
label_string
197-
|> String.split(@label_splitter, trim: true)
197+
|> String.split(label_splitter(), trim: true)
198198
|> Enum.map(&String.trim/1)
199199
|> Enum.chunk_every(2, 2, :discard)
200200
end
201+
202+
defp label_splitter, do: ~r/;|:/
201203
end

lib/new_relic/util/vendor.ex

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,15 @@ defmodule NewRelic.Util.Vendor do
4040
end
4141
end
4242

43-
@cgroup_matcher ~r/\d+:.*cpu[,:].*(?<id>[0-9a-f]{64}).*/
43+
defp cgroup_matcher, do: ~r/\d+:.*cpu[,:].*(?<id>[0-9a-f]{64}).*/
44+
4445
defp docker_vendor_map(cgroup_filename) do
4546
File.read(cgroup_filename)
4647
|> case do
4748
{:ok, cgroup_file} ->
4849
cgroup_file
4950
|> String.split("\n", trim: true)
50-
|> Enum.find_value(&Regex.named_captures(@cgroup_matcher, &1))
51+
|> Enum.find_value(&Regex.named_captures(cgroup_matcher(), &1))
5152

5253
_ ->
5354
nil

0 commit comments

Comments
 (0)