Skip to content

Commit 4c11063

Browse files
feat(php): add support for php 8.5 (#491)
Co-authored-by: Philip-R-Beckwith <74079252+Philip-R-Beckwith@users.noreply.github.com>
1 parent 9a30835 commit 4c11063

File tree

8 files changed

+29
-5
lines changed

8 files changed

+29
-5
lines changed

api/v1alpha2/instrumentation_webhook.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ var acceptableLangs = []string{
107107
"go",
108108
"java",
109109
"nodejs",
110-
"php-7.2", "php-7.3", "php-7.4", "php-8.0", "php-8.1", "php-8.2", "php-8.3", "php-8.4",
110+
"php-7.2", "php-7.3", "php-7.4", "php-8.0", "php-8.1", "php-8.2", "php-8.3", "php-8.4", "php-8.5",
111111
"python",
112112
"ruby",
113113
}

api/v1beta1/instrumentation_webhook.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ var acceptableLangs = []string{
107107
"go",
108108
"java",
109109
"nodejs",
110-
"php-7.2", "php-7.3", "php-7.4", "php-8.0", "php-8.1", "php-8.2", "php-8.3", "php-8.4",
110+
"php-7.2", "php-7.3", "php-7.4", "php-8.0", "php-8.1", "php-8.2", "php-8.3", "php-8.4", "php-8.5",
111111
"python",
112112
"ruby",
113113
}

api/v1beta2/instrumentation_webhook.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ var acceptableLangs = []string{
152152
"go",
153153
"java",
154154
"nodejs",
155-
"php-7.2", "php-7.3", "php-7.4", "php-8.0", "php-8.1", "php-8.2", "php-8.3", "php-8.4",
155+
"php-7.2", "php-7.3", "php-7.4", "php-8.0", "php-8.1", "php-8.2", "php-8.3", "php-8.4", "php-8.5",
156156
"python",
157157
"ruby",
158158
}

api/v1beta3/instrumentation_webhook.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ var acceptableLangs = []string{
152152
"go",
153153
"java",
154154
"nodejs",
155-
"php-7.2", "php-7.3", "php-7.4", "php-8.0", "php-8.1", "php-8.2", "php-8.3", "php-8.4",
155+
"php-7.2", "php-7.3", "php-7.4", "php-8.0", "php-8.1", "php-8.2", "php-8.3", "php-8.4", "php-8.5",
156156
"python",
157157
"ruby",
158158
}

instrumentation.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,7 @@ The supported language agents. PHP being an exception, and currently requires s
503503
| php-8.2 |
504504
| php-8.3 |
505505
| php-8.4 |
506+
| php-8.5 |
506507
| python |
507508
| ruby |
508509

@@ -526,6 +527,7 @@ Custom-built images can be used and specified.
526527
| php-8.2 | newrelic/newrelic-php-init:latest | amd64,arm64 | linux | glibc |
527528
| php-8.3 | newrelic/newrelic-php-init:latest | amd64,arm64 | linux | glibc |
528529
| php-8.4 | newrelic/newrelic-php-init:latest | amd64,arm64 | linux | glibc |
530+
| php-8.5 | newrelic/newrelic-php-init:latest | amd64,arm64 | linux | glibc |
529531
| php-7.2 | newrelic/newrelic-php-init:musl | amd64 | linux | musl |
530532
| php-7.3 | newrelic/newrelic-php-init:musl | amd64 | linux | musl |
531533
| php-7.4 | newrelic/newrelic-php-init:musl | amd64 | linux | musl |
@@ -534,6 +536,7 @@ Custom-built images can be used and specified.
534536
| php-8.2 | newrelic/newrelic-php-init:musl | amd64,arm64 | linux | musl |
535537
| php-8.3 | newrelic/newrelic-php-init:musl | amd64,arm64 | linux | musl |
536538
| php-8.4 | newrelic/newrelic-php-init:musl | amd64,arm64 | linux | musl |
539+
| php-8.5 | newrelic/newrelic-php-init:musl | amd64,arm64 | linux | musl |
537540
| python | newrelic/newrelic-python-init:latest | | linux | |
538541
| ruby | newrelic/newrelic-ruby-init:latest | | linux | |
539542

internal/apm/php.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ const (
4848
php82 acceptVersion = "php-8.2"
4949
php83 acceptVersion = "php-8.3"
5050
php84 acceptVersion = "php-8.4"
51+
php85 acceptVersion = "php-8.5"
5152
)
5253

5354
var phpApiMap = map[acceptVersion]string{
@@ -59,9 +60,10 @@ var phpApiMap = map[acceptVersion]string{
5960
php82: "20220829",
6061
php83: "20230831",
6162
php84: "20240924",
63+
php85: "20250925",
6264
}
6365

64-
var phpAcceptVersions = []acceptVersion{php72, php73, php74, php80, php81, php82, php83, php84}
66+
var phpAcceptVersions = []acceptVersion{php72, php73, php74, php80, php81, php82, php83, php84, php85}
6567

6668
type acceptVersion string
6769

internal/instrumentation/mutator.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ var langRoots = map[string]string{
292292
"php-8.2": "php",
293293
"php-8.3": "php",
294294
"php-8.4": "php",
295+
"php-8.5": "php",
295296
"python": "python",
296297
"ruby": "ruby",
297298
}
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
apiVersion: newrelic.com/v1beta2
2+
kind: Instrumentation
3+
metadata:
4+
labels:
5+
app.kubernetes.io/name: instrumentation
6+
app.kubernetes.io/created-by: k8s-agents-operator
7+
name: newrelic-instrumentation-php85
8+
spec:
9+
podLabelSelector:
10+
matchExpressions:
11+
- key: "app.newrelic.instrumentation"
12+
operator: "In"
13+
values: ["newrelic-php-agent"]
14+
containerSelector:
15+
namesFromPodAnnotation: mycompany.annotation
16+
agent:
17+
language: php-8.5
18+
image: newrelic/newrelic-php-init:musl

0 commit comments

Comments
 (0)