Skip to content

Commit 9f144fd

Browse files
authored
Merge pull request #1636 from newrelic/servlet-init-null-check
Null checks on ServletContext in servlet instrumentation modules.
2 parents a4feb9d + 07d77c7 commit 9f144fd

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

instrumentation/servlet-2.4/src/main/java/javax/servlet/Servlet_Instrumentation.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ public abstract class Servlet_Instrumentation {
2525

2626
@Trace(dispatcher = true)
2727
public void init(ServletConfig config) {
28-
AgentBridge.privateApi.setServerInfo(config.getServletContext().getServerInfo());
28+
ServletContext ctx = config.getServletContext();
29+
if (ctx != null && ctx.getServerInfo() != null) {
30+
AgentBridge.privateApi.setServerInfo(ctx.getServerInfo());
31+
}
2932

3033
Weaver.callOriginal();
3134
}

instrumentation/servlet-5.0/src/main/java/jakarta/servlet/Servlet_Instrumentation.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ public abstract class Servlet_Instrumentation {
2525

2626
@Trace(dispatcher = true)
2727
public void init(ServletConfig config) {
28-
AgentBridge.privateApi.setServerInfo(config.getServletContext().getServerInfo());
28+
ServletContext ctx = config.getServletContext();
29+
if (ctx != null && ctx.getServerInfo() != null) {
30+
AgentBridge.privateApi.setServerInfo(ctx.getServerInfo());
31+
}
2932

3033
Weaver.callOriginal();
3134
}

instrumentation/servlet-6.0/src/main/java/jakarta/servlet/Servlet_Instrumentation.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ public abstract class Servlet_Instrumentation {
2424

2525
@Trace(dispatcher = true)
2626
public void init(ServletConfig config) {
27-
AgentBridge.privateApi.setServerInfo(config.getServletContext().getServerInfo());
27+
ServletContext ctx = config.getServletContext();
28+
if (ctx != null && ctx.getServerInfo() != null) {
29+
AgentBridge.privateApi.setServerInfo(ctx.getServerInfo());
30+
}
2831

2932
Weaver.callOriginal();
3033
}

0 commit comments

Comments
 (0)