free better

ZNeumann · ZNeumann · commit 18fff7abc952 · 2024-10-01T11:08:29.000-04:00
diff --git a/agent/php_internal_instrument.c b/agent/php_internal_instrument.c
@@ -1551,7 +1551,7 @@ NR_INNER_WRAPPER(memcached_add_server) {
     instance_metric = nr_formatf("Datastore/instance/Memcached/%s/%s",
                                instance->host, instance->port_path_or_id);
     nrm_force_add(NRPRG(txn)->unscoped_metrics, instance_metric, 0);
-    nr_free(instance);
+    nr_php_datastore_instance_destroy(instance);
     nr_free(instance_metric);
   }
   zcaught = nr_zend_call_old_handler(nr_wrapper->oldhandler,
@@ -1582,7 +1582,7 @@ NR_INNER_WRAPPER(memcached_add_servers) {
           instance_metric = nr_formatf("Datastore/instance/Memcached/%s/%s",
                                        instance->host, instance->port_path_or_id);
           nrm_force_add(NRPRG(txn)->unscoped_metrics, instance_metric, 0);
-          nr_free(instance);
+          nr_php_datastore_instance_destroy(instance);
           nr_free(instance_metric);
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -1551,7 +1551,7 @@ NR_INNER_WRAPPER(memcached_add_server) {`
`1551`	`1551`	`instance_metric = nr_formatf("Datastore/instance/Memcached/%s/%s",`
`1552`	`1552`	`instance->host, instance->port_path_or_id);`
`1553`	`1553`	`nrm_force_add(NRPRG(txn)->unscoped_metrics, instance_metric, 0);`
`1554`		`- nr_free(instance);`
	`1554`	`+ nr_php_datastore_instance_destroy(instance);`
`1555`	`1555`	`nr_free(instance_metric);`
`1556`	`1556`	`}`
`1557`	`1557`	`zcaught = nr_zend_call_old_handler(nr_wrapper->oldhandler,`
`@@ -1582,7 +1582,7 @@ NR_INNER_WRAPPER(memcached_add_servers) {`
`1582`	`1582`	`instance_metric = nr_formatf("Datastore/instance/Memcached/%s/%s",`
`1583`	`1583`	`instance->host, instance->port_path_or_id);`
`1584`	`1584`	`nrm_force_add(NRPRG(txn)->unscoped_metrics, instance_metric, 0);`
`1585`		`- nr_free(instance);`
	`1585`	`+ nr_php_datastore_instance_destroy(instance);`
`1586`	`1586`	`nr_free(instance_metric);`
`1587`	`1587`	`}`
`1588`	`1588`	`}`