add clarifying comments for test splits

ZNeumann · ZNeumann · commit 2ee7d4e30734 · 2025-01-07T08:54:17.000-07:00
diff --git a/tests/integration/api/error_group_callback/test_error_group_callback_error_web.php84.php b/tests/integration/api/error_group_callback/test_error_group_callback_error_web.php84.php
@@ -6,6 +6,7 @@
 
 /*DESCRIPTION
 Tests newrelic_set_error_group_callback() API for Web errors.
+PHP 8.4+ can no longer use E_USER_ERROR.
 */
 
 /*SKIPIF
diff --git a/tests/integration/attributes/test_transaction_closure_clm.php84.php b/tests/integration/attributes/test_transaction_closure_clm.php84.php
@@ -7,6 +7,7 @@
 /*DESCRIPTION
 The agent should send code level metrics (CLM) including function name,
 class name, and lineno for closures.
+PHP 8.4+ names closures differently.
  */
 
 /*SKIPIF
diff --git a/tests/integration/attributes/test_transaction_closure_clm_off.php84.php b/tests/integration/attributes/test_transaction_closure_clm_off.php84.php
@@ -6,6 +6,7 @@
 
 /*DESCRIPTION
 The agent should *not* send code level metrics (CLM) when disabled.
+PHP 8.4+ names closures differently.
  */
 
 /*SKIPIF
diff --git a/tests/integration/errors/test_E_DEPRECATED_2.php84.php b/tests/integration/errors/test_E_DEPRECATED_2.php84.php
@@ -6,6 +6,7 @@
 
 /*DESCRIPTION
 The agent should capture and report deprecation warnings.
+PHP 8.4+ can no longer use E_USER_ERROR.
 */
 
 /*SKIPIF
diff --git a/tests/integration/errors/test_uncaught_handled_exception_02.php84.php b/tests/integration/errors/test_uncaught_handled_exception_02.php84.php
@@ -9,6 +9,7 @@
 the agent should record the error and add error attributes on all spans leading to uncaught exception as
 well as the one throwing the exception. Error attributtes are not expected on the root span (because
 the exception has been handled) as well as on the span created for exception handler.
+PHP 8.4+ names closures differently.
 */
 
 /*INI
diff --git a/tests/integration/jit/function/test_span_events_are_created_upon_caught_error.php84.php b/tests/integration/jit/function/test_span_events_are_created_upon_caught_error.php84.php
@@ -9,6 +9,7 @@
 when an error is generated and handled by user error handler. The span that
 generated the error should have error attributes. Additionally error events
 should be created.
+PHP 8.4+ names closures differently.
 */
 
 /*SKIPIF
diff --git a/tests/integration/jit/function/test_span_events_are_created_upon_uncaught_error.php84.php b/tests/integration/jit/function/test_span_events_are_created_upon_uncaught_error.php84.php
@@ -7,6 +7,7 @@
 /*DESCRIPTION
 Test that span events are correctly created from any eligible segment, even
 when an error is generated and left to the default error handler.
+PHP 8.4+ can no longer use E_USER_ERROR.
 */
 
 /*SKIPIF
diff --git a/tests/integration/jit/function/test_span_events_are_created_upon_uncaught_handled_exception.php84.php b/tests/integration/jit/function/test_span_events_are_created_upon_uncaught_handled_exception.php84.php
@@ -9,6 +9,7 @@
 when an uncaught exception is handled by the user exception handler. The
 span that generated the exception should have error attributes. Additionally
 error events should be created.
+PHP 8.4+ names closures differently.
 */
 
 /*SKIPIF
diff --git a/tests/integration/jit/tracing/test_span_events_are_created_upon_caught_error.php84.php b/tests/integration/jit/tracing/test_span_events_are_created_upon_caught_error.php84.php
@@ -9,6 +9,7 @@
 when an error is generated and handled by user error handler. The span that
 generated the error should have error attributes. Additionally error events
 should be created.
+PHP 8.4+ names closures differently.
 */
 
 /*SKIPIF
diff --git a/tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_error.php84.php b/tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_error.php84.php
@@ -7,6 +7,7 @@
 /*DESCRIPTION
 Test that span events are correctly created from any eligible segment, even
 when an error is generated and left to the default error handler.
+PHP 8.4+ can no longer use E_USER_ERROR.
 */
 
 /*SKIPIF
diff --git a/tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_handled_exception.php84.php b/tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_handled_exception.php84.php
@@ -9,6 +9,7 @@
 when an uncaught exception is handled by the user exception handler. The
 span that generated the exception should have error attributes. Additionally
 error events should be created.
+PHP 8.4+ names closures differently.
 */
 
 /*SKIPIF
diff --git a/tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_error.php84.php b/tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_error.php84.php
@@ -7,6 +7,7 @@
 /*DESCRIPTION
 Test that span events are correctly created from any eligible segment, even
 when an error is generated and left to the default error handler.
+PHP 8.4+ can no longer use E_USER_ERROR.
 */
 
 /*SKIPIF
diff --git a/tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_handled_exception.php84.php b/tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_handled_exception.php84.php
@@ -9,6 +9,7 @@
 when an uncaught exception is handled by the user exception handler. The
 span that generated the exception should have error attributes. Additionally
 error events should be created for PHP 8+ and OAPI.
+PHP 8.4+ names closures differently
 */
 
 /*SKIPIF
diff --git a/tests/integration/span_events/test_span_events_are_created_upon_caught_error.php84.php b/tests/integration/span_events/test_span_events_are_created_upon_caught_error.php84.php
@@ -7,6 +7,7 @@
 /*DESCRIPTION
 Test that span events are correctly created from any eligible segment, even
 when an error is generated and handled.
+PHP 8.4+ names closures differently.
 */
 
 /*SKIPIF
diff --git a/tests/integration/span_events/test_span_events_are_created_upon_uncaught_error.php84.php b/tests/integration/span_events/test_span_events_are_created_upon_uncaught_error.php84.php
@@ -7,6 +7,7 @@
 /*DESCRIPTION
 Test that span events are correctly created from any eligible segment, even
 when an error is generated and left to the default error handler.
+PHP 8.4+ can no longer use E_USER_ERROR.
 */
 
 /*SKIPIF
diff --git a/tests/integration/span_events/test_span_events_are_created_upon_uncaught_handled_exception.php84.php b/tests/integration/span_events/test_span_events_are_created_upon_uncaught_handled_exception.php84.php
@@ -9,6 +9,7 @@
 when an uncaught exception is handled by the user exception handler. The
 span that generated the exception should have error attributes. Additionally
 error events should be created.
+PHP 8.4+ names closures differently.
 */
 
 /*SKIPIF
