review: remove frees

bduranleau-nr · bduranleau-nr · commit 3c68c3d7063b · 2025-02-27T10:52:41.000-06:00
diff --git a/agent/fw_drupal8.c b/agent/fw_drupal8.c
@@ -637,7 +637,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {
           nrl_warning(NRL_FRAMEWORK,
                       "hookImplementationsMap[hook = %s]: invalid value",
                       NRSAFESTR(ZEND_STRING_VALUE(hook_key)));
-          nr_free(hookpath);
           return false;
         }
 
@@ -649,7 +648,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {
             nrl_warning(NRL_FRAMEWORK,
                         "hookImplementationsMap[class = %s]: invalid value",
                         NRSAFESTR(ZEND_STRING_VALUE(class_key)));
-            nr_free(hookpath);
             return false;
           }
 
@@ -662,7 +660,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {
               nrl_warning(NRL_FRAMEWORK,
                           "hookImplementationsMap[method = %s]: invalid value",
                           NRSAFESTR(ZEND_STRING_VALUE(method_key)));
-              nr_free(hookpath);
               return false;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -637,7 +637,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {`
`637`	`637`	`nrl_warning(NRL_FRAMEWORK,`
`638`	`638`	`"hookImplementationsMap[hook = %s]: invalid value",`
`639`	`639`	`NRSAFESTR(ZEND_STRING_VALUE(hook_key)));`
`640`		`- nr_free(hookpath);`
`641`	`640`	`return false;`
`642`	`641`	`}`
`643`	`642`
`@@ -649,7 +648,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {`
`649`	`648`	`nrl_warning(NRL_FRAMEWORK,`
`650`	`649`	`"hookImplementationsMap[class = %s]: invalid value",`
`651`	`650`	`NRSAFESTR(ZEND_STRING_VALUE(class_key)));`
`652`		`- nr_free(hookpath);`
`653`	`651`	`return false;`
`654`	`652`	`}`
`655`	`653`
`@@ -662,7 +660,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {`
`662`	`660`	`nrl_warning(NRL_FRAMEWORK,`
`663`	`661`	`"hookImplementationsMap[method = %s]: invalid value",`
`664`	`662`	`NRSAFESTR(ZEND_STRING_VALUE(method_key)));`
`665`		`- nr_free(hookpath);`
`666`	`663`	`return false;`
`667`	`664`	`}`
`668`	`665`