fixup! b887845

Document input validation requirements for functions that no longer do that
because it is expected to be done upstream.

Author: lavarou

agent/php_user_instrument.c

@@ -353,6 +353,13 @@ nruserfn_t* nr_php_user_wraprec_create(void) {
 }
 
 #if ZEND_MODULE_API_NO < ZEND_8_0_X_API_NO
+
+/* This function expects full_name and full_name_len to be validated with
+ * nr_php_user_instrument_is_name_valid() before being passed in.
+ * Specifically, it requires that:
+ * - full_name_len be greater than 0
+ * - full_name must not be NULL and must not end with `:` (colon) . */
+
 static nruserfn_t* nr_php_user_wraprec_create_named(const char* full_name,
                                                     int full_name_len) {
   int i;

agent/php_user_instrument_wraprec_hashmap.c

@@ -393,6 +393,12 @@ nr_status_t nr_php_user_instrument_wraprec_hashmap_init(void) {
   return NR_SUCCESS;
 }
 
+/* This function expects namestr and namestrlen to be validated with
+ * nr_php_user_instrument_is_name_valid() before being passed in.
+ * Specifically, it requires that:
+ * - namestrlen be greater than 0
+ * - namestr must not be NULL and must not end with `:` (colon) . */
+
 nruserfn_t* nr_php_user_instrument_wraprec_hashmap_add(const char* namestr, size_t namestrlen) {
   nr_scope_hashmap_key_t scope_key = {0};
   nr_func_hashmap_key_t func_key = {0};