Skip to content

Commit 765888d

Browse files
authored
Merge pull request #1091 from newrelic/dev
Release 11.10
2 parents 143cf0c + 4706504 commit 765888d

39 files changed

+507
-104
lines changed

.github/workflows/make-agent.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,6 @@ jobs:
4040
path: php-agent
4141
repository: ${{ inputs.origin }}/newrelic-php-agent
4242
ref: ${{ inputs.ref }}
43-
- name: Enable arm64 emulation
44-
if: ${{ inputs.arch == 'arm64' }}
45-
uses: docker/setup-qemu-action@v3
46-
with:
47-
image: tonistiigi/binfmt:${{vars.BINFMT_IMAGE_VERSION}}
48-
platforms: arm64
4943
- name: Login to Docker Hub
5044
uses: docker/login-action@v3
5145
with:

.github/workflows/make-integration-tests.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ on:
2424
description: 'runner type'
2525
required: true
2626
type: string
27+
use-valgrind:
28+
required: true
29+
default: false
30+
type: boolean
2731

2832
jobs:
2933
test-agent:
@@ -56,12 +60,6 @@ jobs:
5660
run: |
5761
chmod 755 php-agent/bin/integration_runner
5862
chmod 755 php-agent/agent/modules/newrelic.so
59-
- name: Enable arm64 emulation
60-
if: ${{ inputs.arch == 'arm64' }}
61-
uses: docker/setup-qemu-action@v3
62-
with:
63-
image: tonistiigi/binfmt:${{vars.BINFMT_IMAGE_VERSION}}
64-
platforms: arm64
6563
- name: Login to Docker Hub
6664
uses: docker/login-action@v3
6765
with:
@@ -83,7 +81,7 @@ jobs:
8381
run: |
8482
docker exec \
8583
-e PHPS=${{matrix.php}} \
86-
-e INTEGRATION_ARGS="-license ${{secrets.NR_TEST_LICENSE}} -collector ${{secrets.NR_COLLECTOR_HOST}} -agent agent/modules/newrelic.so" \
84+
-e INTEGRATION_ARGS="-license ${{secrets.NR_TEST_LICENSE}} -collector ${{secrets.NR_COLLECTOR_HOST}} -agent agent/modules/newrelic.so ${{ inputs.use-valgrind && '-valgrind /usr/bin/valgrind' }}" \
8785
-e APP_supportability=${{secrets.APP_SUPPORTABILITY}} \
8886
-e ACCOUNT_supportability=${{secrets.ACCOUNT_SUPPORTABILITY}} \
8987
-e ACCOUNT_supportability_trusted=${{secrets.ACCOUNT_SUPPORTABILITY_TRUSTED}} \

.github/workflows/run-integration-tests.yml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,16 @@ on:
2121
runner-type:
2222
description: 'Type of a runner to use for integration tests on arm64'
2323
required: true
24-
default: 'ubuntu-20.04-4core'
24+
default: 'ubuntu-24.04-arm'
2525
type: choice
2626
options:
27-
- ubuntu-20.04-4core
28-
- ubuntu-20.04-8core
29-
- ubuntu-20.04-16core
30-
- ubuntu-22.04-4core
31-
- ubuntu-latest
32-
27+
- ubuntu-22.04-arm
28+
- ubuntu-24.04-arm
29+
use-valgrind:
30+
description: 'Use valgrind?'
31+
required: true
32+
default: false
33+
type: boolean
3334
jobs:
3435
build-test-runner-amd64:
3536
uses: ./.github/workflows/make-for-platform-on-arch.yml
@@ -55,7 +56,7 @@ jobs:
5556
artifact-name: integration_runner
5657
artifact-pattern: bin/integration_runner
5758
arch: arm64
58-
runs-on: ubuntu-latest
59+
runs-on: ${{inputs.runner-type}}
5960
secrets: inherit
6061

6162
build-agent-amd64:
@@ -72,7 +73,7 @@ jobs:
7273
origin: ${{ inputs.origin }}
7374
ref: ${{ inputs.ref }}
7475
arch: arm64
75-
runs-on: ubuntu-latest
76+
runs-on: ${{inputs.runner-type}}
7677
secrets: inherit
7778

7879
test-amd64:
@@ -81,6 +82,7 @@ jobs:
8182
with:
8283
origin: ${{ inputs.origin }}
8384
ref: ${{ inputs.ref }}
85+
use-valgrind: ${{ inputs.use-valgrind }}
8486
arch: amd64
8587
runs-on: ubuntu-latest
8688
continue-on-error: false
@@ -91,6 +93,7 @@ jobs:
9193
with:
9294
origin: ${{ inputs.origin }}
9395
ref: ${{ inputs.ref }}
96+
use-valgrind: ${{ inputs.use-valgrind }}
9497
arch: arm64
9598
runs-on: ${{inputs.runner-type}}
9699
continue-on-error: true

0 commit comments

Comments
 (0)