simplify user instrumentation initialization handling

The only way nr_php_user_instrument_wraprec_hashmap_init can fail is when
memory cannot be allocated, which is already considered a fatal error and
causes php process to exit so there's no point in returning failure status
in such case. Additionally, nrl_* (logging) does not work until INI has
been processed so the error message wouldn't get logged anyway.

Author: lavarou

agent/php_minit.c

@@ -499,12 +499,7 @@ PHP_MINIT_FUNCTION(newrelic) {
    *  - newrelic.webtransaction.name.functions
    *  - newrelic.transaction_tracer.custom
   */
-  if (NR_SUCCESS != nr_php_user_instrument_wraprec_hashmap_init()) {
-    nrl_error(NRL_AGENT,
-              "%s: Failed to initialize user function instrumentation and user "
-              "functions will not be instrumented.",
-              __func__);
-  }
+  nr_php_user_instrument_wraprec_hashmap_init();
 #endif
 
   nr_php_register_ini_entries(module_number TSRMLS_CC);

agent/php_user_instrument_wraprec_hashmap.c

@@ -380,17 +380,13 @@ static void nr_php_user_instrument_wraprec_hashmap_name2keys(
   func->name_hash = zend_hash_func(func->name, func->name_len);
 }
 
-nr_status_t nr_php_user_instrument_wraprec_hashmap_init(void) {
+void nr_php_user_instrument_wraprec_hashmap_init(void) {
   if (NULL == scope_ht) {
     scope_ht = nr_scope_hashmap_create_internal(0);
   }
   if (NULL == global_funcs_ht) {
     global_funcs_ht = nr_func_hashmap_create_internal(0);
   }
-  if (NULL == scope_ht || NULL == global_funcs_ht) {
-    return NR_FAILURE;
-  }
-  return NR_SUCCESS;
 }
 
 /* This function expects namestr and namestrlen to be validated with

agent/php_user_instrument_wraprec_hashmap.h

@@ -10,7 +10,7 @@
 
 // clang-format off
 
-extern nr_status_t nr_php_user_instrument_wraprec_hashmap_init(void);
+extern void nr_php_user_instrument_wraprec_hashmap_init(void);
 extern nruserfn_t* nr_php_user_instrument_wraprec_hashmap_add(const char* namestr, size_t namestrlen);
 extern nruserfn_t* nr_php_user_instrument_wraprec_hashmap_get(zend_string *func_name, zend_string *scope_name);
 extern void nr_php_user_instrument_wraprec_hashmap_destroy(void);

agent/tests/test_user_instrument_wraprec_hashmap.c

@@ -20,7 +20,6 @@ tlib_parallel_info_t parallel_info
 #define FUNCTION_NAME "global_function"
 
 static void test_wraprecs_hashmap() {
-  nr_status_t init_status;
   nruserfn_t *wraprec, *found_wraprec;
   zend_string *func_name, *scope_name, *method_name;
 
@@ -39,8 +38,7 @@ static void test_wraprecs_hashmap() {
   tlib_pass_if_null("adding valid method before init", wraprec);
 
   // Initialize the hashmap
-  init_status = nr_php_user_instrument_wraprec_hashmap_init();
-  tlib_pass_if_int_equal("wraprec hashmap init", NR_SUCCESS, init_status);
+  nr_php_user_instrument_wraprec_hashmap_init();
 
   // Test valid operations after initializing the hashmap
   wraprec = nr_php_user_instrument_wraprec_hashmap_add(NR_PSTR(FUNCTION_NAME));