Skip to content

Commit 8ff820d

Browse files
authored
fix(tests): Fixes package-name-only test case (#903)
The PHP package test was not being correctly checked for the case where the package was specified as `package_name_only` and a version was actually created for the package.
1 parent f000c13 commit 8ff820d

File tree

1 file changed

+11
-1
lines changed
  • daemon/internal/newrelic/integration

1 file changed

+11
-1
lines changed

daemon/internal/newrelic/integration/test.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,17 @@ func (t *Test) comparePhpPackages(harvest *newrelic.Harvest) {
604604
expected_version = override_version.(string)
605605
}
606606

607-
if testPackageNameOnly || expected_version == actualPackages[i].Version {
607+
if testPackageNameOnly {
608+
if " " != actualPackages[i].Version {
609+
t.Fail(fmt.Errorf("Expected no package version and a package version was detected - expected \" \" actual %+v. ",
610+
actualPackages[i].Version))
611+
return
612+
} else {
613+
continue
614+
}
615+
}
616+
617+
if expected_version == actualPackages[i].Version {
608618
continue
609619
}
610620
}

0 commit comments

Comments
 (0)