chore(agent): remove obsolete code (8/17) (#1077)

This PR removes obsolete `PHP7` codeblocks. PR: 8/17

Author: hahuja2

agent/php_hash.c

@@ -5,7 +5,6 @@
 #include "php_agent.h"
 #include "php_hash.h"
 
-#ifdef PHP7
 static int nr_php_zend_hash_ptr_apply_wrapper(zval* value,
                                               int num_args,
                                               va_list args,
@@ -24,26 +23,6 @@ static int nr_php_zend_hash_ptr_apply_wrapper(zval* value,
 
   return (apply_func)(Z_PTR_P(value), arg, hash_key TSRMLS_CC);
 }
-#else
-static int nr_php_zend_hash_ptr_apply_wrapper(void* value TSRMLS_DC,
-                                              int num_args,
-                                              va_list args,
-                                              zend_hash_key* hash_key) {
-  nr_php_ptr_apply_t apply_func;
-  void* arg;
-
-  (void)num_args;
-
-  apply_func = (nr_php_ptr_apply_t)va_arg(args, nr_php_ptr_apply_t);
-  arg = (void*)va_arg(args, void*);
-
-  if (NULL == value) {
-    return ZEND_HASH_APPLY_KEEP;
-  }
-
-  return (apply_func)(value, arg, hash_key TSRMLS_CC);
-}
-#endif /* PHP7 */
 
 void nr_php_zend_hash_ptr_apply(HashTable* ht,
                                 nr_php_ptr_apply_t apply_func,
@@ -53,7 +32,6 @@ void nr_php_zend_hash_ptr_apply(HashTable* ht,
       apply_func, arg);
 }
 
-#ifdef PHP7
 static int nr_php_zend_hash_zval_apply_wrapper(zval* value,
                                                int num_args,
                                                va_list args,
@@ -68,28 +46,6 @@ static int nr_php_zend_hash_zval_apply_wrapper(zval* value,
 
   return (apply_func)(value, arg, hash_key TSRMLS_CC);
 }
-#else
-static int nr_php_zend_hash_zval_apply_wrapper(zval** value TSRMLS_DC,
-                                               int num_args,
-                                               va_list args,
-                                               zend_hash_key* hash_key) {
-  nr_php_zval_apply_t apply_func;
-  void* arg;
-
-  (void)num_args;
-
-  apply_func = (nr_php_zval_apply_t)va_arg(args, nr_php_zval_apply_t);
-  arg = (void*)va_arg(args, void*);
-
-  if ((NULL == value) || (NULL == *value)) {
-    return ZEND_HASH_APPLY_KEEP;
-  }
-
-  (void)num_args;
-
-  return (apply_func)(*value, arg, hash_key TSRMLS_CC);
-}
-#endif /* PHP7 */
 
 void nr_php_zend_hash_zval_apply(HashTable* ht,
                                  nr_php_zval_apply_t apply_func,
@@ -104,17 +60,13 @@ int nr_php_zend_hash_del(HashTable* ht, const char* key) {
     return 0;
   }
 
-#ifdef PHP7
   int retval;
   zend_string* zs = zend_string_init(key, nr_strlen(key), 0);
 
   retval = zend_hash_del(ht, zs);
   zend_string_free(zs);
 
   return (SUCCESS == retval);
-#else
-  return (SUCCESS == zend_hash_del(ht, key, nr_strlen(key) + 1));
-#endif /* PHP7 */
 }
 
 int nr_php_zend_hash_exists(const HashTable* ht, const char* key) {
@@ -124,14 +76,9 @@ int nr_php_zend_hash_exists(const HashTable* ht, const char* key) {
  * lookups!
  */
 
-#ifdef PHP7
   return zend_hash_str_exists(ht, key, nr_strlen(key));
-#else
-  return zend_hash_exists(ht, key, nr_strlen(key) + 1);
-#endif /* PHP7 */
 }
 
-#ifdef PHP7
 zval* nr_php_zend_hash_find(const HashTable* ht, const char* key) {
   if ((NULL == ht) || (NULL == key) || ('\0' == key[0])) {
     return NULL;
@@ -155,49 +102,3 @@ zval* nr_php_zend_hash_index_find(const HashTable* ht, zend_ulong index) {
 
   return zend_hash_index_find(ht, index);
 }
-#else  /* Not PHP7 */
-void* nr_php_zend_hash_find_ptr(const HashTable* ht, const char* key) {
-  void* data = NULL;
-  int keylen;
-  int rv;
-
-  if ((0 == ht) || (0 == key)) {
-    return NULL;
-  }
-
-  keylen = nr_strlen(key);
-  if (keylen <= 0) {
-    return NULL;
-  }
-  keylen += 1; /* Lookup length requires null terminator */
-
-  rv = zend_hash_find(ht, key, keylen, &data);
-  if (SUCCESS != rv) {
-    return NULL;
-  }
-
-  return data;
-}
-
-zval* nr_php_zend_hash_find(const HashTable* ht, const char* key) {
-  zval** zv_pp = (zval**)nr_php_zend_hash_find_ptr(ht, key);
-
-  if (NULL == zv_pp) {
-    return NULL;
-  }
-
-  return *zv_pp;
-}
-
-zval* nr_php_zend_hash_index_find(const HashTable* ht, zend_ulong index) {
-  void* data = NULL;
-  int rv;
-
-  rv = zend_hash_index_find(ht, index, &data);
-  if ((SUCCESS != rv) || (NULL == data)) {
-    return NULL;
-  }
-
-  return *((zval**)data);
-}
-#endif /* PHP7 */