review: remove frees

bduranleau-nr · bduranleau-nr · commit aa17d9e4f165 · 2025-05-08T11:54:03.000-05:00
diff --git a/agent/fw_drupal8.c b/agent/fw_drupal8.c
@@ -640,7 +640,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {
           nrl_warning(NRL_FRAMEWORK,
                       "hookImplementationsMap[hook = %s]: invalid value",
                       NRSAFESTR(ZEND_STRING_VALUE(hook_key)));
-          nr_free(hookpath);
           return false;
         }
 
@@ -652,7 +651,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {
             nrl_warning(NRL_FRAMEWORK,
                         "hookImplementationsMap[class = %s]: invalid value",
                         NRSAFESTR(ZEND_STRING_VALUE(class_key)));
-            nr_free(hookpath);
             return false;
           }
 
@@ -665,7 +663,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {
               nrl_warning(NRL_FRAMEWORK,
                           "hookImplementationsMap[method = %s]: invalid value",
                           NRSAFESTR(ZEND_STRING_VALUE(method_key)));
-              nr_free(hookpath);
               return false;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -640,7 +640,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {`
`640`	`640`	`nrl_warning(NRL_FRAMEWORK,`
`641`	`641`	`"hookImplementationsMap[hook = %s]: invalid value",`
`642`	`642`	`NRSAFESTR(ZEND_STRING_VALUE(hook_key)));`
`643`		`- nr_free(hookpath);`
`644`	`643`	`return false;`
`645`	`644`	`}`
`646`	`645`
`@@ -652,7 +651,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {`
`652`	`651`	`nrl_warning(NRL_FRAMEWORK,`
`653`	`652`	`"hookImplementationsMap[class = %s]: invalid value",`
`654`	`653`	`NRSAFESTR(ZEND_STRING_VALUE(class_key)));`
`655`		`- nr_free(hookpath);`
`656`	`654`	`return false;`
`657`	`655`	`}`
`658`	`656`
`@@ -665,7 +663,6 @@ static bool nr_drupal_hook_attribute_instrument(zval* module_handler) {`
`665`	`663`	`nrl_warning(NRL_FRAMEWORK,`
`666`	`664`	`"hookImplementationsMap[method = %s]: invalid value",`
`667`	`665`	`NRSAFESTR(ZEND_STRING_VALUE(method_key)));`
`668`		`- nr_free(hookpath);`
`669`	`666`	`return false;`
`670`	`667`	`}`
`671`	`668`